Thread (4 messages) 4 messages, 1 author, 7d ago

[PATCH 4/4] Input: tps6507x-ts - fix input device parent assignment

flat view
DORMANTno replies IN LINUX-NEXT

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2026-10-08 09:47:47
Also in: lkml
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Dmitry Torokhov, Linus Torvalds

Queued in linux-next as 2b4bcdd40ca0 on 2026-10-14.

Assigning the MFD parent device (tsc->dev) instead of the platform
device (&pdev->dev) as the parent device after
devm_input_allocate_device(&pdev->dev) splits devres management across
two devices. As a result, input_register_device() attaches the devm
unregistration action to the MFD parent device rather than the platform
device, leaving the input device registered when the platform driver
unbinds.

devm_input_allocate_device(&pdev->dev) already sets
input_dev->dev.parent to &pdev->dev. Drop the redundant and erroneous
assignment.

Fixes: 2e2a0db8c88d ("Input: tps6507x-ts - update to devm_* API")
Assisted-by: LLM
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/tps6507x-ts.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/input/touchscreen/tps6507x-ts.c b/drivers/input/touchscreen/tps6507x-ts.c
index f48871767763..e84dc3ea1fcb 100644
--- a/drivers/input/touchscreen/tps6507x-ts.c
+++ b/drivers/input/touchscreen/tps6507x-ts.c
@@ -251,7 +251,6 @@ static int tps6507x_ts_probe(struct platform_device *pdev)
 
 	input_dev->name = "TPS6507x Touchscreen";
 	input_dev->phys = tsc->phys;
-	input_dev->dev.parent = tsc->dev;
 	input_dev->id.bustype = BUS_I2C;
 	if (init_data) {
 		input_dev->id.vendor = init_data->vendor;
-- 
2.56.0.385.gd3acb90ef8-goog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help