Re: [PATCH v5 1/6] dt-bindings: input: Add Himax HX83102J touchscreen
flat view
From: sashiko-bot@kernel.org
Date: 2026-10-03 17:56:10
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] dt-bindings: inherited properties blocked by additionalProperties: false -- commit e01de01cb0d4342a5cf5aaa82a8d34629a2ccf17 Author: Allen_Lin [off-list ref] dt-bindings: input: Add Himax HX83102J touchscreen This commit adds the device tree binding for the Himax HX83102J TDDI controller. It defines the touch function connected over SPI and the shared reset and analog supplies.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml new file mode 100644 index 0000000000000..c9f229bf9ca7b --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml
[ ... ]
quoted hunk ↗ jump to hunk
+ display-reset-gpios: + maxItems: 1 + description: + Reset of the display function, usually driven by the panel. Asserting + it also resets the touch function. + + spi-cpha: true + + spi-cpol: true + + spi-max-frequency: true + + panel: true
[Severity: Medium] Are these standard properties redundantly added here to bypass the strict local validation constraint? Changing the schema to use unevaluatedProperties: false at the bottom of the file would make these explicit declarations unnecessary.
quoted hunk ↗ jump to hunk
+ + firmware-name: + description: Specify the file name for firmware loading. + +required: + - compatible + - reg + - interrupts + - reset-gpios + - panel + - vccd-supply + - vsn-supply + - vsp-supply + - display-reset-gpios + +additionalProperties: false
[Severity: Medium] Does this prevent the inherited properties from touchscreen.yaml and spi-peripheral-props.yaml from being used? In JSON schema validation, additionalProperties: false only checks the local properties block. It rejects standard properties defined in the referenced schemas (such as touchscreen-size-x or touchscreen-inverted-y) unless they are redundantly declared locally. Adding standard touchscreen properties to a board device tree node using this compatible string will cause make dt_binding_check to fail with 'additional properties are not allowed'. Changing this to unevaluatedProperties: false is the architectural standard for dt-bindings schemas that use $ref to inherit properties. -- Sashiko AI review · https://sashiko.dev/#/patchset/20261003142741.48634-1-michal@nozomi.space?part=1