Re: [PATCH] dt-bindings: input: Add AD7147 CapTouch schema
flat view
From: sashiko-bot@kernel.org
Date: 2026-09-21 23:36:52
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] dt-bindings: compatible string inappropriately encodes Linux driver name - [Medium] dt-bindings: schema omits essential properties for programmable layout -- commit e423e496cad8df9cf9b56b68a72e3590fb50e497 Author: Rob Herring (Arm) [off-list ref] dt-bindings: input: Add AD7147 CapTouch schema Add a schema for the Analog Devices AD7147 CapTouch controller used by the Microsoft Lumia 950 and Lumia 950 XL device trees. Document its I2C address, interrupt, and optional vcc supply.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/input/adi,ad714x.yaml b/Documentation/devicetree/bindings/input/adi,ad714x.yaml new file mode 100644 index 0000000000000..8351c28147ee1 --- /dev/null +++ b/Documentation/devicetree/bindings/input/adi,ad714x.yaml@@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/adi,ad714x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices AD7147 CapTouch Programmable Controller + +maintainers: + - Michael Hennerich <michael.hennerich@analog.com> + +properties: + compatible: + const: adi,ad7147_captouch
[Severity: Medium] Does this compatible string inappropriately encode a Linux-specific driver name? The correct hardware name is adi,ad7147. By defining adi,ad7147_captouch instead, it seems to exploit the Linux I2C subsystem's fallback match to the existing ad7147_captouch I2C ID in ad714x-i2c.c, avoiding the need to properly patch the driver with an of_match_table. Because Device Tree bindings form a cross-OS ABI contract, encoding a Linux-specific abstraction leaks Linux internals to bootloaders and other operating systems, establishing a permanently flawed ABI for this hardware.
quoted hunk ↗ jump to hunk
+ + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + vcc-supply: true + +required: + - compatible + - reg + - interrupts + +additionalProperties: false
[Severity: Medium] Does this schema omit the essential properties needed to describe the physical layout of this programmable controller? The AD7147 requires its physical layout (number of sliders, buttons, wheels, touchpads, and stages) to be configured. The Linux driver (ad714x.c) currently relies entirely on struct ad714x_platform_data for this, but the provided schema completely omits any properties or child nodes to express this physical layout in the Device Tree. Because the schema enforces additionalProperties: false, any attempt by a board device tree (like the Lumia 950) to actually add the missing but essential configuration properties will be strictly rejected by dt_binding_check, making it functionally useless for platform initialization. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260921232731.3134965-1-robh@kernel.org?part=1