Re: [PATCH v3 18/19] dt-bindings: input: touchscreen: goodix: Add binding for GT970
From: sashiko-bot@kernel.org
Date: 2026-09-21 18:29:23
Also in:
dri-devel, linux-clk, linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] input: touchscreen: goodix: incomplete GT970 support causes config length mismatch -- commit fb8dc3b0be08be515a9f9b03de04ea7da115bf6f Author: Muzaffer Kadir [off-list ref] dt-bindings: input: touchscreen: goodix: Add binding for GT970 This commit adds the goodix,gt970 compatible string to the DT binding. It specifies that the GT970 should fall back to the goodix,gt911 compatible string to use the GT911 driver configuration.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml index a26a54d63a1c0..4be2c137abd7c 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml@@ -14,21 +14,26 @@ allOf: properties: compatible:
[ ... ]
+ - items: + - enum: + - goodix,gt970 + - const: goodix,gt911
[Severity: Medium] Will this require a corresponding driver change to work correctly? When the driver probes the device, it uses goodix_get_chip_data() to choose configuration parameters based on the hardware ID read from the device, rather than the DT compatible string. Because "970" is missing from the goodix_chip_ids[] array in drivers/input/touchscreen/goodix.c, it appears the driver will ignore this DT fallback and apply the generic 240-byte configuration instead of GT911's 186-byte configuration. Could this incorrect configuration length cause the driver to read or write past the end of the configuration registers? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260921-msm8952-initial-support-v3-0-b96fd3fe298b@mainlining.org?part=18