Re: [PATCH 1/7] Input: gscps2 - clean up driver code style and structure

On Tue, Sep 15, 2026 at 11:51:28AM +0200, Helge Deller wrote:

Hi Dmitry,

On 8/30/26 22:52, Dmitry Torokhov wrote:

quoted

Clean up code style issues and function ordering in the gscps2 driver:
- Reorder functions to place gscps2_interrupt() before its callers,
   allowing removal of its forward declaration.
- Change gscps2_enable() to accept a boolean parameter and remove the
   ENABLE and DISABLE macro definitions.
- Convert printk() calls to dev_dbg() and dev_warn().
- Fix operator spacing and multi-variable assignment.
- Add spinlock comment and use cpu_relax() in spin-wait loop.

Assisted-by: LLM
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
  drivers/input/serio/gscps2.c | 208 +++++++++++++++++++------------------------
  1 file changed, 91 insertions(+), 117 deletions(-)

you may add for the whole series:

Acked-by: Helge Deller <deller@gmx.de>
Tested-by: Helge Deller <deller@gmx.de>

Thank you Helge!

-- 
Dmitry