Re: [PATCH v1] HID: sensor-hub: synchronize multi-value read cancellation

On Thu, 17 Sep 2026 01:16:09 +0000
"Zhang, Lixu" [off-list ref] wrote:

quoted

-----Original Message-----
From: Zhang, Lixu
Sent: Friday, September 11, 2026 1:17 PM
To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>; Yibo Tan
[off-list ref]; Jiri Kosina [off-list ref]; Jonathan Cameron
[off-list ref]; Benjamin Tissoires [off-list ref]
Cc: Shevchenko, Andriy <redacted>; linux-
input@vger.kernel.org; linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: RE: [PATCH v1] HID: sensor-hub: synchronize multi-value read
cancellation
 

quoted

-----Original Message-----
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
Sent: Friday, September 11, 2026 2:29 AM
To: Yibo Tan <redacted>; Jiri Kosina <jikos@kernel.org>;
Jonathan Cameron [off-list ref]; Benjamin Tissoires
[off-list ref]
Cc: Zhang, Lixu <lixu.zhang@intel.com>; Shevchenko, Andriy
[off-list ref]; linux-input@vger.kernel.org; linux-
iio@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] HID: sensor-hub: synchronize multi-value read
cancellation

On Thu, 2026-09-10 at 19:23 +0800, Yibo Tan wrote:  

quoted

sensor_hub_input_attr_read_values() publishes a caller-owned buffer
to the raw-event path. If its interruptible wait times out or is
interrupted, it clears pending.status without taking data->lock and
returns.
 

Hi Lixu,

Please give me quick test. Change itself looks good, not sure if we
need something more.  

Hi Srinivas,

The machine is currently running other tests. Once they are done next week, I
will run a quick test on this change and get back to you with feedback.  

Tested-by: Zhang Lixu <lixu.zhang@intel.com>

I did some basic validation on a real HID sensor hub / rotation sensor system and did not see a regression from this patch.

Great. Thanks!

Yibo Tan, please can you spin a v2 addressing the other feedback.

thanks,

Jonathan

Thanks,
Lixu

quoted

Thanks,
Lixu
 

quoted

Thanks,
Srinivas