On Wed, Sep 16, 2026 at 05:22:24PM +0300, Muzaffer Kadir wrote:
quoted hunk ↗ jump to hunk
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ pinctrl-0 = <&gpio_hall_sensor_default>, <&gpio_keys_default>;
+ pinctrl-names = "default";
+
+ event-hall-sensor {
+ label = "Hall Effect Sensor";
+ gpios = <&tlmm 46 GPIO_ACTIVE_LOW>;
+ linux,input-type = <EV_SW>;
+ linux,code = <SW_LID>;
+ linux,can-disable;
+ wakeup-source;
+ };
+
+ button-volume-up {
button node before event, to keep things sorted by name
quoted hunk ↗ jump to hunk
+ label = "Volume Up";
+ gpios = <&tlmm 85 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_VOLUMEUP>;
+ debounce-interval = <15>;
+ wakeup-source;
+ };
+ };
+
+ multi-led {
+ compatible = "leds-group-multicolor";
+ color = <LED_COLOR_ID_RGB>;
+ function = LED_FUNCTION_INDICATOR;
+ leds = <&red_status>, <&green_status>, <&blue_status>;
+ };
+
+ reserved-memory {
Please run dt-check-style and fix some of the less disputable reported issues.
quoted hunk ↗ jump to hunk
+ cont_splash_mem: cont-splash@83200000 {
+ reg = <0x0 0x83200000 0x0 (1080 * 1920 * 3)>;
+ no-map;
+ };
+ };
+
+ vph_pwr: regulator-vph-pwr {
+ compatible = "regulator-fixed";
+ regulator-name = "vph-pwr";
+ regulator-always-on;
+ regulator-boot-on;
+ };
+};
+
+&adsp {
+ status = "okay";
+};
+
+&blsp1_i2c2 {
+ status = "okay";
+ /* SMB1351 @1d charger */
+ /* wsa881x-i2c @e @44 @f @45 audio amplifier */
+};
+
+&blsp1_i2c3 {
+ status = "okay";
+
+ /* himax,852x@48 Touchscreen */
+
+ touchscreen@5d {
+ compatible = "goodix,gt970", "goodix,gt911";
+ reg = <0x5d>;
+ interrupts-extended = <&tlmm 65 IRQ_TYPE_EDGE_FALLING>;
+ irq-gpios = <&tlmm 65 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&tlmm 64 GPIO_ACTIVE_HIGH>;
+ AVDD28-supply = <&pm8950_l10>;
+ VDDIO-supply = <&pm8950_l6>;
+
+ pinctrl-0 = <&touchscreen_default>;
+ pinctrl-names = "default";
+
+ touchscreen-size-x = <1080>;
+ touchscreen-size-y = <1920>;
+ };
+};
+
+&blsp2_i2c1 {
+ status = "okay";
+
+ /* FUSB301 @25 USB-C Controller */
+
+ tpa6130a2: tpa6130a2@60 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).
quoted hunk ↗ jump to hunk
+ compatible = "ti,tpa6130a2";
+ pinctrl-0 = <&tpa6130a2_default>;
+ pinctrl-names = "default";
+ reg = <0x60>;
+ power-gpio = <&tlmm 61 GPIO_ACTIVE_HIGH>;
+ Vdd-supply = <&pm8950_l22>;
+ };
+
+ tusb320: tusb320@67 {
Same here
Best regards,
Krzysztof