[PATCH 00/28] Replace remaining strlcat() call sites with snprintf()/seq_buf() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 01/28] ALSA: ac97: Refactor snd_ac97_get_name() to use snprintf() · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 01/28] ALSA: ac97: Refactor snd_ac97_get_name() to use snprintf() · Kees Cook <kees@kernel.org> · 2026-09-15
Re: [PATCH 01/28] ALSA: ac97: Refactor snd_ac97_get_name() to use snprintf() · David Laight <hidden> · 2026-09-16
[PATCH 03/28] ARM: atags: Replace strlcat() with snprintf() for cmdline extend · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 03/28] ARM: atags: Replace strlcat() with snprintf() for cmdline extend · Kees Cook <kees@kernel.org> · 2026-09-15
Re: [PATCH 03/28] ARM: atags: Replace strlcat() with snprintf() for cmdline extend · Bill Wendling <morbo@google.com> · 2026-09-16
Re: [PATCH 03/28] ARM: atags: Replace strlcat() with snprintf() for cmdline extend · sashiko-bot@kernel.org · 2026-09-17
[PATCH 02/28] sunrpc: Refactor rpc_sockaddr2uaddr() to use snprintf() instead of strlcat() · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 02/28] sunrpc: Refactor rpc_sockaddr2uaddr() to use snprintf() instead of strlcat() · Jeff Layton <jlayton@kernel.org> · 2026-09-15
[PATCH 08/28] devlink: Refactor strlcat() to seq_buf in __devlink_compat_running_version() · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 08/28] devlink: Refactor strlcat() to seq_buf in __devlink_compat_running_version() · sashiko-bot@kernel.org · 2026-09-17
[PATCH 05/28] ALSA: usb-audio: Refactor usb_audio_make_longname() to use seq_buf · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 05/28] ALSA: usb-audio: Refactor usb_audio_make_longname() to use seq_buf · sashiko-bot@kernel.org · 2026-09-17
[PATCH 04/28] scsi: bfa: Use snprintf() in bfa_fcs_fabric_nsymb_init() · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 04/28] scsi: bfa: Use snprintf() in bfa_fcs_fabric_nsymb_init() · sashiko-bot@kernel.org · 2026-09-17
[PATCH 07/28] scsi: bfa: Use snprintf() in bfa_fcs_fabric_psymb_init() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 06/28] comedi: comedi_bond: Refactor strlcat() to seq_buf in do_dev_config() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 11/28] wifi: brcmfmac: Replace strlcat() with snprintf() in brcmf_fw_alloc_request() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 10/28] of/fdt: Replace strlcat() with snprintf() in early_init_dt_scan_chosen() · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 10/28] of/fdt: Replace strlcat() with snprintf() in early_init_dt_scan_chosen() · Rob Herring <robh@kernel.org> · 2026-09-15
[PATCH 09/28] drm/dp_mst: Refactor build_mst_prop_path() to use seq_buf · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 12/28] fortify: Convert strlcat() to snprintf() in strcat() · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 12/28] fortify: Convert strlcat() to snprintf() in strcat() · sashiko-bot@kernel.org · 2026-09-17
[PATCH 14/28] ALSA: usb-audio: Refactor append_ctl_name() to use snprintf() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 13/28] i40e: Replace strlcat() with snprintf() in i40e_nvm_version_str() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 15/28] orangefs: Use seq_buf for debug help string generation · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 16/28] pinctrl: samsung: Use snprintf() to construct pin bank names · Bill Wendling <morbo@google.com> · 2026-09-15
RE: [PATCH 16/28] pinctrl: samsung: Use snprintf() to construct pin bank names · Loktionov, Aleksandr <hidden> · 2026-09-16
[PATCH 17/28] MIPS: cmdline: Refactor bootcmdline_append() to use snprintf() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 18/28] LoongArch: Refactor bootcmdline_init() to use seq_buf instead of strlcat() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 20/28] parisc: Refactor strlcat() to seq_buf in setup_cmdline() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 21/28] NFS: nfsroot: Refactor root_nfs_cat() to use snprintf() · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 21/28] NFS: nfsroot: Refactor root_nfs_cat() to use snprintf() · Kees Cook <kees@kernel.org> · 2026-09-15
Re: [PATCH 21/28] NFS: nfsroot: Refactor root_nfs_cat() to use snprintf() · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 26/28] wifi: wil6210: Refactor resume_triggers2string() to use seq_buf · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 22/28] media: si2165: Use snprintf() to format frontend name · Bill Wendling <morbo@google.com> · 2026-09-15
RE: [PATCH 22/28] media: si2165: Use snprintf() to format frontend name · Loktionov, Aleksandr <hidden> · 2026-09-16
[PATCH 25/28] EDAC/thunderx: Replace strlcat() with seq_buf · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 25/28] EDAC/thunderx: Replace strlcat() with seq_buf · Kees Cook <kees@kernel.org> · 2026-09-15
Re: [PATCH 25/28] EDAC/thunderx: Replace strlcat() with seq_buf · Borislav Petkov <bp@alien8.de> · 2026-09-16
Re: [PATCH 25/28] EDAC/thunderx: Replace strlcat() with seq_buf · Bill Wendling <morbo@google.com> · 2026-09-16
[PATCH 23/28] Input: synaptics_usb - use seq_buf and snprintf() for name and phys · Bill Wendling <morbo@google.com> · 2026-09-15
[PATCH 24/28] EDAC/thunderx: Fix stale error context in thunderx_l2c_threaded_isr() · Bill Wendling <morbo@google.com> · 2026-09-15
RE: [PATCH 24/28] EDAC/thunderx: Fix stale error context in thunderx_l2c_threaded_isr() · Loktionov, Aleksandr <hidden> · 2026-09-16
[PATCH 27/28] drm/xe/pf: Convert strlcat() to seq_buf in control_read() · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 27/28] drm/xe/pf: Convert strlcat() to seq_buf in control_read() · Kees Cook <kees@kernel.org> · 2026-09-15
[PATCH 28/28] drm/xe/pf: Refactor strlcat() to seq_buf in sched_group_engines_read() · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 28/28] drm/xe/pf: Refactor strlcat() to seq_buf in sched_group_engines_read() · Kees Cook <kees@kernel.org> · 2026-09-15
[PATCH 19/28] x86/setup: Use snprintf() to concatenate builtin and boot command lines · Bill Wendling <morbo@google.com> · 2026-09-15
Re: [PATCH 19/28] x86/setup: Use snprintf() to concatenate builtin and boot command lines · sashiko-bot@kernel.org · 2026-09-17
Re: [PATCH 00/28] Replace remaining strlcat() call sites with snprintf()/seq_buf() · Takashi Iwai <hidden> · 2026-09-15
Re: [PATCH 00/28] Replace remaining strlcat() call sites with snprintf()/seq_buf() · Kees Cook <kees@kernel.org> · 2026-09-15

Re: [PATCH 00/28] Replace remaining strlcat() call sites with snprintf()/seq_buf()

From: Takashi Iwai <hidden>
Date: 2026-09-15 11:30:14
Also in: dri-devel, intel-wired-lan, intel-xe, linux-devicetree, linux-edac, linux-gpio, linux-hardening, linux-media, linux-mips, linux-nfs, linux-samsung-soc, linux-scsi, linux-sound, linux-wireless, lkml, loongarch, netdev

On Tue, 15 Sep 2026 10:18:17 +0200,
Bill Wendling wrote:

strlcat() is deprecated: like strcat(), it requires re-scanning the
destination string from the beginning on every call, which is O(n^2)
when used to build up a string incrementally, and its truncation
behavior is easy to get wrong.

... but what many of your patches do is to replace strlcat() with
open-codes, which is more error-prone and easier to get wrong than
a single strlcat() call.

See:

  https://github.com/KSPP/linux/issues/370

It's clear that strlcat() isn't perfect and sometimes inefficient.
But blindly deprecating without providing a good alternative doesn't
sound like a right approach to me.


thanks,

Takashi

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help