Re: [PATCH v3 1/2] Input: soc_button_array - fix MS Surface Pro 11 probe failure
flat view
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2026-09-13 23:43:40
Also in:
platform-driver-x86, stable
On Wed, Sep 09, 2026 at 11:39:33AM +0200, Hans de Goede wrote:
On the MS Surface Pro 11 soc_button_array probing races with the GPIO
driver probing. If soc_button_array wins the race then gpiod_get() returns
EPROBE_DEFER, which should normally take care of retrying later, but
the soc_button_array code deliberately ignores EPROBE_DEFER causing it
to fail its probe() which causes the volume and power buttons to now work.
The ignoring of EPROBE_DEFER is there to deal with a problem specific to
older Bay Trail (BYT) and Cherry Trail (CHT) tablets which often use this
driver. Modify the error handling to only ignore EPROBE_DEFER on BYT and
CHT platforms and propagate EPROBE_DEFER normally on other platforms.
Fixes: bcf059578980 ("Input: soc_button_array - partial revert of support for newer surface devices")
Cc: stable@vger.kernel.org
Reported-by: Sergey Lebedev <redacted>
Closes: https://lore.kernel.org/lkml/20260830141355.55898-1-lsa.uz@pm.me/ (local)
Signed-off-by: Hans de Goede <redacted>Applied the lot, thank you. -- Dmitry