Re: i2c-hid: IRQ storm from Synaptics SYNA32A4 (06CB:CE17) after resume
From: Jiri Kosina <jikos@kernel.org>
Date: 2026-09-11 14:57:55
On Tue, 1 Sep 2026, Matt Ervin wrote:
quoted hunk
What I have NOT established --------------------------- I have not built and tested a patched kernel, so I cannot confirm that I2C_HID_QUIRK_RESET_ON_RESUME itself is sufficient. What I know is that a manual unbind/bind -- which performs a reset -- clears the storm reliably, and that it returns on the next resume without it. I am happy to test a patch. Proposed change, if it is the right call ----------------------------------------diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h#define I2C_VENDOR_ID_SYNAPTICS 0x06cb #define I2C_PRODUCT_ID_SYNAPTICS_SYNA2393 0x7a13 +#define I2C_PRODUCT_ID_SYNAPTICS_SYNA32A4 0xce17diff --git a/drivers/hid/i2c-hid/i2c-hid-core.cb/drivers/hid/i2c-hid/i2c-hid-core.c--- a/drivers/hid/i2c-hid/i2c-hid-core.c +++ b/drivers/hid/i2c-hid/i2c-hid-core.c{ I2C_VENDOR_ID_SYNAPTICS, I2C_PRODUCT_ID_SYNAPTICS_SYNA2393, I2C_HID_QUIRK_RESET_ON_RESUME }, + { I2C_VENDOR_ID_SYNAPTICS, I2C_PRODUCT_ID_SYNAPTICS_SYNA32A4, + I2C_HID_QUIRK_RESET_ON_RESUME },
That seems like a proper fix indeed. Why haven't you tested it, given that you have the hardware and write "happy to test a patch"? :) Once you test it, can you please submit it properly [1] so that we can merge it? Thanks. [1] Documentation/process/submitting-patches.rst -- Jiri Kosina SUSE Labs