Re: [PATCH 1/5] m68k: Fix atari mouse movement

Hi,

On Sun, 16 Aug 2026 at 15:04, Michael Schmitz [off-list ref] wrote:

Hi Geert,

Am 15.08.2026 um 11:15 schrieb Michael Schmitz:

quoted

quoted

quoted

--- a/drivers/input/mouse/atarimouse.c
+++ b/drivers/input/mouse/atarimouse.c

@@ -70,9 +70,12 @@ static void atamouse_interrupt(char *buf)

Alternative, you could change/restore the function's signature to take a
"signed char *".

Agreed, but without a way to test this, I'd rather wait for Miro
confirming that change also fixed the issue.

I have just tested it. The new version works equally well,

I have just noticed that if I enable the pointer signedness warnings, I get:

make ARCH=m68k CROSS_COMPILE=m68k-linux-gnu- KCFLAGS=-Wpointer-sign
arch/m68k/atari/atakeyb.o

arch/m68k/atari/atakeyb.c: In function 'atari_keyboard_interrupt':
arch/m68k/atari/atakeyb.c:263:82: warning: pointer targets in
passing argument 1 of 'atari_input_mouse_interrupt_hook' differ in
signedness [-Wpointer-sign]

atari_input_mouse_interrupt_hook(kb_state.buf);
arch/m68k/atari/atakeyb.c:263:82: note: expected 'signed char *' but
argument is of type 'unsigned char *'

I guess this is expected but wanted to mention it just to be on the safe side.

-- 
http://mikro.atari.org