Re: [PATCH 2/2] arm64: dts: qcom: microsoft-romulus13: enable touchscreen
From: sashiko-bot@kernel.org
Date: 2026-09-07 05:52:10
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Missing Pinctrl Configuration for Touchscreen GPIOs -- commit bbc74de3ce23fd59e3587b624f0acdca53aaf32a Author: fQwQf [off-list ref] arm64: dts: qcom: microsoft-romulus13: enable touchscreen This commit adds the device tree node for the ITCH MSHW0468 touchscreen on the Microsoft Surface Laptop 7. It describes the I2C controller, interrupt, reset GPIO, and HID descriptor address to allow enumeration by i2c-hid.
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus13.dts b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus13.dts --- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus13.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus13.dts
[ ... ]
quoted hunk ↗ jump to hunk
+&i2c8 { + clock-frequency = <400000>; + + status = "okay"; + + touchscreen@34 { + compatible = "hid-over-i2c"; + reg = <0x34>; + hid-descr-addr = <0x0000>; + + interrupts-extended = <&tlmm 38 IRQ_TYPE_LEVEL_LOW>; + reset-gpios = <&tlmm 31 GPIO_ACTIVE_LOW>;
[Severity: Medium] Does this node need explicit pinctrl configuration for the touchscreen GPIOs? Currently, the interrupts-extended and reset-gpios properties are claimed without a corresponding pinctrl-0 array. On Qualcomm platforms, relying on the bootloader's initial pinmux and pinconf state can be unreliable if power domains cycle during system suspend, potentially losing the configuration. For an active-low interrupt line, a missing pull-up bias could cause the pin to float and generate spurious interrupts, while a missing pinmux might prevent the device from resuming correctly.
+ }; +};
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260907054339.12409-1-fqwqf@fqwqf.xyz?part=2