Re: [PATCH v3 1/3] dt-bindings: input: Add Qualcomm SPMI PMIC haptics
From: sashiko-bot@kernel.org
Date: 2026-07-14 05:31:18
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Missing Parent MFD Schema Update for qcom,spmi-haptics --
--- Patch [1]: [PATCH v3 1/3] dt-bindings: input: Add Qualcomm SPMI PMIC haptics ---commit f137781e6c2b5a0d469e1be3c8ce374d67796f68 Author: Fenglin Wu [off-list ref] dt-bindings: input: Add Qualcomm SPMI PMIC haptics This patch adds a new device tree binding document for the haptics module integrated into Qualcomm PMICs. It covers hardware variants like the HAP530_HV module in the PMIH0108 PMIC.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml b/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml new file mode 100644 index 0000000000000..b1a69e9886ee6 --- /dev/null +++ b/Documentation/devicetree/bindings/input/qcom,spmi-haptics.yaml
[ ... ]
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ pmic {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ haptics@f000 {
+ compatible = "qcom,pmih0108-haptics", "qcom,spmi-haptics";
+ reg = <0xf000>, <0xf100>;[Severity: Medium] Will this new haptics node cause validation failures in the parent PMIC node? The parent MFD binding (Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml) enforces strict child node validation using additionalProperties: false. Because this patch introduces a new sub-device schema without adding a corresponding pattern (like ^haptics@[0-9a-f]+$) to the parent schema's patternProperties, it seems any actual device tree utilizing this haptics node will fail dtbs_check with an 'Unevaluated properties are not allowed' error. Does the parent schema need to be updated in the same series to permit this node?
+ reg-names = "cfg", "ptn"; + interrupts = <0x7 0xf0 0x1 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "fifo-empty"; + + qcom,vmax-microvolt = <1300000>; + qcom,lra-period-us = <5880>; + }; + };
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260713-qcom-spmi-haptics-v3-0-c931bb7cb94f@oss.qualcomm.com?part=1