RE: [PATCH 4/4] HID: Intel-thc-hid: Intel-quickspi: Remove redundant dev_err()
From: "Xu, Even" <even.xu@intel.com>
Date: 2026-07-14 00:50:13
Also in:
lkml
Thanks for the patch! If this is the case, can you also do the same change for intel-quicki2c driver? Best Regards, Even Xu
quoted hunk ↗ jump to hunk
-----Original Message----- From: Pan Chuang <redacted> Sent: Monday, July 13, 2026 9:25 PM To: Xu, Even <even.xu@intel.com>; Sun, Xinpeng <xinpeng.sun@intel.com>; Jiri Kosina [off-list ref]; Benjamin Tissoires [off-list ref]; Pan Chuang [off-list ref]; Sakari Ailus [off-list ref]; Abhishek Tamboli [off-list ref]; Danny D. [off-list ref]; open list:HID CORE LAYER <linux- input@vger.kernel.org>; open list [off-list ref] Subject: [PATCH 4/4] HID: Intel-thc-hid: Intel-quickspi: Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang <redacted> --- drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.cb/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c index 4ae2e1718b30..504ef3c842ab 100644--- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c@@ -636,11 +636,8 @@ static int quickspi_probe(struct pci_dev *pdev, quickspi_irq_thread_handler, IRQF_ONESHOT, KBUILD_MODNAME, qsdev); - if (ret) { - dev_err(&pdev->dev, - "Failed to request threaded IRQ, irq = %d.\n", pdev-quoted
irq);+ if (ret) goto dev_deinit; - } ret = reset_tic(qsdev); if (ret) { -- 2.34.1