From: Miles Krause <redacted>
Detection status bit 7 indicates that a calibration cycle is in
progress. Define a name for the bit and use it in the polling
condition instead of an open-coded shift and comparison.
No functional change.
Signed-off-by: Miles Krause <redacted>
---
Compile-tested on x86_64 with:
make O=out allmodconfig
make O=out W=1 drivers/input/keyboard/qt1050.o
Sparse-tested with:
make O=out-sparse allmodconfig
make O=out-sparse C=1 CHECK=sparse drivers/input/keyboard/qt1050.o
---
drivers/input/keyboard/qt1050.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/qt1050.c b/drivers/input/keyboard/qt1050.c
index f9f480c91032..2371ac027aab 100644
--- a/drivers/input/keyboard/qt1050.c
+++ b/drivers/input/keyboard/qt1050.c
@@ -27,7 +27,8 @@
#define QT1050_FW_VERSION 0x01
/* Detection status */
-#define QT1050_DET_STATUS 0x02
+#define QT1050_DET_STATUS 0x02
+#define QT1050_DET_STATUS_CALIBRATE BIT(7)
/* Key status */
#define QT1050_KEY_STATUS 0x03
@@ -498,7 +499,8 @@ static int qt1050_probe(struct i2c_client *client)
return err;
}
err = regmap_read_poll_timeout(ts->regmap, QT1050_DET_STATUS, status,
- status >> 7 == 1, 10000, 200000);
+ status & QT1050_DET_STATUS_CALIBRATE,
+ 10000, 200000);
if (err) {
dev_err(dev, "Calibration failed: %d\n", err);
return err;
---
base-commit: c8f174900926d3b58cd048ac33b4cbb3de419bfe
change-id: 20260710-qt1050-calibration-status-bit-0b2e479ffd4b
Best regards,
--
Miles Krause [off-list ref]