[PATCH 1/3] HID: wiimote: turn on the LEDs indicating the controller id
From: Rafael Passos <hidden>
Date: 2026-07-10 15:35:33
Subsystem:
hid core layer, the rest, wiimote hid driver · Maintainers:
Jiri Kosina, Benjamin Tissoires, Linus Torvalds, David Rheinsberg
The behavior in a Wii/Wii U console is to have each controller turn on a different LED indicating the controller id. This commit implements the same behavior using the ida struct. Unlike switch controllers, each ID only turns one LED (from 1 to 4). Signed-off-by: Rafael Passos <redacted> --- drivers/hid/hid-wiimote-core.c | 46 +++++++++++++++++++++++++++++----- drivers/hid/hid-wiimote.h | 8 ++++++ 2 files changed, 48 insertions(+), 6 deletions(-)
diff --git a/drivers/hid/hid-wiimote-core.c b/drivers/hid/hid-wiimote-core.c
index 63c4fa8fbb9b..0d36a38bdcda 100644
--- a/drivers/hid/hid-wiimote-core.c
+++ b/drivers/hid/hid-wiimote-core.c@@ -671,6 +671,12 @@ static void wiimote_modules_load(struct wiimote_data *wdata, spin_lock_irq(&wdata->state.lock); wdata->state.devtype = devtype; spin_unlock_irq(&wdata->state.lock); + + /* after loading all modules, set the LED for the player ID cycling from 1 to 4*/ + scoped_guard(spinlock_irqsave, &wdata->state.lock) { + wiiproto_req_leds(wdata, player_leds[(wdata->instance_id - 1) % 4]); + } + return; error:
@@ -855,11 +861,11 @@ static void wiimote_init_set_type(struct wiimote_data *wdata, done: if (devtype == WIIMOTE_DEV_GENERIC) - hid_info(wdata->hdev, "cannot detect device; NAME: %s VID: %04x PID: %04x EXT: %04x\n", - name, vendor, product, exttype); + hid_info(wdata->hdev, "cannot detect device; NAME: %s VID: %04x PID: %04x EXT: %04x (%d)\n", + name, vendor, product, exttype, wdata->instance_id); else - hid_info(wdata->hdev, "detected device: %s\n", - wiimote_devtype_names[devtype]); + hid_info(wdata->hdev, "detected device: %s (%d)\n", + wiimote_devtype_names[devtype], wdata->instance_id); wiimote_modules_load(wdata, devtype); }
@@ -1786,11 +1792,15 @@ static void wiimote_destroy(struct wiimote_data *wdata) kfree(wdata); } +/* Global id allocator for wii remotes */ +static DEFINE_IDA(wiimote_ida); + static int wiimote_hid_probe(struct hid_device *hdev, const struct hid_device_id *id) { struct wiimote_data *wdata; int ret; + int instance_id; hdev->quirks |= HID_QUIRK_NO_INIT_REPORTS;
@@ -1834,7 +1844,15 @@ static int wiimote_hid_probe(struct hid_device *hdev, if (ret) goto err_free; - hid_info(hdev, "New device registered\n"); + instance_id = ida_alloc_min(&wiimote_ida, 1, GFP_KERNEL); + if (!instance_id) { + hid_err(hdev, "cannot allocate controller id, defaulting to 1\n"); + instance_id = 1; + } + + wdata->instance_id = instance_id; + + hid_info(hdev, "New device registered (Wiimote %d)\n", instance_id); /* schedule device detection */ wiimote_schedule(wdata);
@@ -1862,6 +1880,8 @@ static void wiimote_hid_remove(struct hid_device *hdev) { struct wiimote_data *wdata = hid_get_drvdata(hdev); + ida_free(&wiimote_ida, wdata->instance_id); + hid_info(hdev, "Device removed\n"); wiimote_destroy(wdata); }
@@ -1887,7 +1907,21 @@ static struct hid_driver wiimote_hid_driver = { .remove = wiimote_hid_remove, .raw_event = wiimote_hid_event, }; -module_hid_driver(wiimote_hid_driver); + + +static int __init wiimote_init(void) +{ + return hid_register_driver(&wiimote_hid_driver); +} + +static void __exit wiimote_exit(void) +{ + hid_unregister_driver(&wiimote_hid_driver); + ida_destroy(&wiimote_ida); +} + +module_init(wiimote_init); +module_exit(wiimote_exit); MODULE_LICENSE("GPL"); MODULE_AUTHOR("David Herrmann <dh.herrmann@gmail.com>");
diff --git a/drivers/hid/hid-wiimote.h b/drivers/hid/hid-wiimote.h
index 9c12f63f6dd2..639f67c24f15 100644
--- a/drivers/hid/hid-wiimote.h
+++ b/drivers/hid/hid-wiimote.h@@ -50,6 +50,13 @@ #define WIIPROTO_FLAGS_IR (WIIPROTO_FLAG_IR_BASIC | WIIPROTO_FLAG_IR_EXT | \ WIIPROTO_FLAG_IR_FULL) +static const __u8 player_leds[] = { + WIIPROTO_FLAG_LED1, + WIIPROTO_FLAG_LED2, + WIIPROTO_FLAG_LED3, + WIIPROTO_FLAG_LED4 +}; + /* return flag for led \num */ #define WIIPROTO_FLAG_LED(num) (WIIPROTO_FLAG_LED1 << (num - 1))
@@ -153,6 +160,7 @@ struct wiimote_data { struct input_dev *mp; struct timer_list timer; struct wiimote_debug *debug; + int instance_id; union { struct input_dev *input;
--
2.53.0