Thread (22 messages) 22 messages, 6 authors, 4d ago

Re: [PATCH v2 2/6] iio: hid-sensors: align function parenthesis for readability

From: Jonathan Cameron <jic23@kernel.org>
Date: 2026-07-04 23:07:50
Also in: linux-iio, lkml

On Fri, 03 Jul 2026 18:09:39 -0700
srinivas pandruvada [off-list ref] wrote:
On Fri, 2026-07-03 at 15:52 +0300, Andy Shevchenko wrote:
quoted
On Thu, Jul 02, 2026 at 06:20:15PM +0100, Jonathan Cameron wrote:  
quoted
On Thu, 02 Jul 2026 21:47:59 +0530
Sanjay Chitroda via B4 Relay
[off-list ref] wrote:
  
quoted
Adjust alignment of parentheses across HID sensor IIO drivers to
improve readability and maintain consistency with kernel coding
style.

While updating the formatting, group related arguments
consistently in
multi-line function signatures where appropriate.

No functional change intended.  
Whilst I appreciate this code isn't quite in line with standards
and usually like that stuff to be fixed up, in this particular case
this is a massive amount of churn.  That churn will make
backporting
fixes etc messier, so I'd like input on whether others consider
this
one worthwhile.  Jiri, Srinivas, Andy etc. What do you think?  
I am fine as long as Srinivas is. I understand pros and cons of this,
but from
time to time we have patches à la this one that messes up with
backporting but
were accepted as a good part of some bigger series.  
I am fine. I guess we will deal with backporting issues as they appear.
We'll go ahead.  So Sanjay, please send a new version rebased on
what I picked up already and with those inconsistencies tidied up.

Thanks,

Jonathan
Thanks,
Srinivas 
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help