Re: [PATCH v6 1/4] firmware_loader: expand firmware error codes with up-to-date error
From: sashiko-bot@kernel.org
Date: 2026-07-02 22:39:45
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added "firmware-duplicate" sysfs error string is omitted from the sysfs ABI documentation and the corresponding selftest script. -- commit 59f39aaf73939b5dbe553a0c6fe3c5d3c9ce3d78 Author: Marco Felsch [off-list ref] firmware_loader: expand firmware error codes with up-to-date error This commit adds FW_UPLOAD_ERR_DUPLICATE to allow drivers to signal that a firmware update is not required. It also updates the error strings in the core sysfs interface and the test firmware module.
quoted hunk ↗ jump to hunk
diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/firmware_loader/sysfs_upload.c --- a/drivers/base/firmware_loader/sysfs_upload.c +++ b/drivers/base/firmware_loader/sysfs_upload.c@@ -28,6 +28,7 @@ static const char * const fw_upload_err_str[] = { [FW_UPLOAD_ERR_RW_ERROR] = "read-write-error", [FW_UPLOAD_ERR_WEAROUT] = "flash-wearout", [FW_UPLOAD_ERR_FW_INVALID] = "firmware-invalid", + [FW_UPLOAD_ERR_DUPLICATE] = "firmware-duplicate",
[Severity: Low] Since firmware-duplicate is now exposed to userspace, should it also be documented in Documentation/ABI/testing/sysfs-class-firmware? The existing documentation lists the other expected error strings but is missing this one. Additionally, does this require an update to the selftests? Looking at tools/testing/selftests/firmware/fw_upload.sh, the errors list is hardcoded: errors="hw-error timeout device-busy invalid-file-size read-write-error flash-wearout" Without adding firmware-duplicate to this list, the new error injection capability added to lib/test_firmware.c might not be exercised by the test suite.
}; static const char *fw_upload_progress(struct device *dev,
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260703-v6-10-topic-touchscreen-axiom-v6-0-1aa50ba3bc5a@pengutronix.de?part=1