Thread (21 messages) 21 messages, 7 authors, 8d ago

Re: [PATCH 2/6] [v5] x86/olpc: select GPIOLIB_LEGACY

From: "Arnd Bergmann" <arnd@kernel.org>
Date: 2026-06-29 13:40:26
Also in: linux-leds, sashiko-reviews

On Mon, Jun 29, 2026, at 15:25, sashiko-bot@kernel.org wrote:
quoted
diff --git a/arch/x86/platform/olpc/olpc-xo1-sci.c b/arch/x86/platform/olpc/olpc-xo1-sci.c
index 30751b42d54ef..a5b47960ba32e 100644
--- a/arch/x86/platform/olpc/olpc-xo1-sci.c
+++ b/arch/x86/platform/olpc/olpc-xo1-sci.c
@@ -9,7 +9,7 @@
 
 #include <linux/cs5535.h>
 #include <linux/device.h>
-#include <linux/gpio.h>
+#include <linux/gpio/legacy.h>
[Severity: Low]
Does this cause a build failure when setup_ec_sci() and other functions in
this file are compiled? It appears include/linux/gpio/legacy.h does not exist
in the tree, and the legacy GPIO APIs might still be declared directly in
include/linux/gpio.h.
The header was added in 7.2-rc1.

     Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help