On 5/29/26 3:16 AM, Harrison Vanderbyl wrote:
Initial device tree for Microsoft Surface Pro 12in
Currently supported:
- UFS
- Touchscreen
- Pen
- USB 3.2 x2 (DP Alt Mode)
- Audio
- Wifi
- Bluetooth
- CDSP
- ADSP
- GPU
Not currently supported:
- Accelerometer
- Front, Back and IR cameras
- IRIS video decoder
Tested on Surface_Pro_12in_1st_Ed_with_Snapdragon_2110
Signed-off-by: Harrison Vanderbyl <redacted>
Reviewed-by: Dmitry Baryshkov <redacted>
---
lg, just a couple nits
[...]
quoted hunk ↗ jump to hunk
+ codec {
+ sound-dai = <&left_spkr>, <&right_spkr>,
+ <&swr0 0>, <&lpass_wsamacro 0>;
Please align the <s
[...]
quoted hunk ↗ jump to hunk
+&i2c9 {
+ clock-frequency = <400000>;
+
+ /* NFC @28, commercial devices only */
+
+ status = "okay";
Because we'd put the subnodes for devices under the 'status' line (DTC
enforces that), please move the comment below as well
Or since it's @28, perhaps it's just nxp,nxp-nci-i2c and it could work
for you ootb?
[...]
quoted hunk ↗ jump to hunk
+&tlmm {
+ gpio-reserved-ranges = <34 2>, /* Unused */
+ <44 4>; /* SPI (TPM) */
Please align the <s (or is it my mail client playing tricks on me?)
Konrad