Re: [PATCH v6] HID: lg-g15 - Add support for Logitech G13.

On Wed, 17 Sep 2025, Leo L. Schwab wrote:

The Logitech G13 is a gaming keypad with general-purpose macro keys,
four LED-backlit macro preset keys, five "menu" keys, backlight toggle
key, an analog thumbstick, RGB LED backlight, and a monochrome LCD
display.

Support input event generation for all keys and the thumbstick, and
expose all LEDs.

Signed-off-by: Leo L. Schwab <redacted>
Reviewed-by: Hans de Goede <hansg@kernel.org>
Tested-by: Kate Hsuan <hpa@redhat.com>
---
Changes in v6:
  - Alter interaction between `brightness` and `brightness_hw_changed`
    for the backlight as advised by Hans de Goede [off-list ref].
  - On probe, query device for current state of HW backlight toggle;
    track in `backlight_disabled` and update sysfs.
  - Ensure non-backlight LED brightnesses report either 0 or 1.
Changes in v5:
  - None; resend v4 due to bounced email submission.
Changes in v4:
  - Minor changes recommended by Hans de Goede [off-list ref].
Changes in v3:
  - Re-revise commit message.
  - Conditionally compile the section depending on
    CONFIG_LEDS_BRIGHTNESS_HW_CHANGED correctly this time.
  - Use led-class-multicolor facilities for the RGB backlight.
  - Changes recommended by Kate Hsuan [off-list ref]:
    - Use guard(mutex) construct.
    - Fix numerous style nits.
Changes in v2:
  - Add `#ifdef CONFIG_LEDS_BRIGHTNESS_HW_CHANGED` bracket around new
    code segment dependent on that feature (fixes test robot build
    error).
  - Use `guard(mutex)` construct in new code (existing code left
    unmodified).
  - Commit message revised.

Applied to hid.git#for-6.19/logitech, thanks.

-- 
Jiri Kosina
SUSE Labs