Re: [PATCH 12/32] media: i2c: max9286: Use %pe format specifier
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Date: 2025-10-13 15:09:46
Also in:
imx, linux-media, linux-renesas-soc, linux-samsung-soc, linux-staging, lkml
Quoting Ricardo Ribalda (2025-10-13 15:14:52)
quoted hunk ↗ jump to hunk
The %pe format specifier is designed to print error pointers. It prints a symbolic error name (eg. -EINVAL) and it makes the code simpler by omitting PTR_ERR(). This patch fixes this cocci report: ./i2c/max9286.c:755:7-14: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Ricardo Ribalda <redacted> --- drivers/media/i2c/max9286.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 7c0961688d6173843f3ae846253d4a8669ae762b..e6e214f8294b83105be02f29966e1d3ed72f8dbe 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c@@ -751,8 +751,8 @@ static int max9286_v4l2_notifier_register(struct max9286_priv *priv) mas = v4l2_async_nf_add_fwnode(&priv->notifier, source->fwnode, struct max9286_asd); if (IS_ERR(mas)) { - dev_err(dev, "Failed to add subdev for source %u: %ld", - i, PTR_ERR(mas)); + dev_err(dev, "Failed to add subdev for source %u: %pe", + i, mas);
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
v4l2_async_nf_cleanup(&priv->notifier);
return PTR_ERR(mas);
}
--
2.51.0.760.g7b8bcc2412-goog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip