Thread (11 messages) 11 messages, 4 authors, 2025-09-29

Re: [PATCH 1/2] dt-bindings: input: pm8941-pwrkey: Document wakeup-source property

From: Luca Weiss <hidden>
Date: 2025-09-29 15:53:04
Also in: linux-arm-msm, linux-devicetree, lkml, phone-devel

On 25-09-25 7:45 atm, Dmitry Torokhov wrote:
On Tue, Sep 09, 2025 at 07:54:33AM -0700, Dmitry Torokhov wrote:
quoted
On Tue, Sep 09, 2025 at 04:41:26PM +0200, Luca Weiss wrote:
quoted
On 2025-09-09 16:33, Krzysztof Kozlowski wrote:
quoted
On 09/09/2025 16:08, Dmitry Torokhov wrote:
quoted
quoted
quoted
    compatible:
      enum:
@@ -36,6 +33,11 @@ properties:
             pin should be configured for pull up.
      $ref: /schemas/types.yaml#/definitions/flag

+  wakeup-source:
+    description: |
+           Button can wake-up the system. Only applicable
for 'resin',
+           'pwrkey' always wakes the system by default.

I'll fix existing code, so don't repeat that style.
If you ack I can reformat on my side to match the patch you just sent.
Reviewed-by: Krzysztof Kozlowski <redacted>
Thanks for fixing that up Krzysztof! I noticed but didn't want to deviate
from the style just for this description. Of course better to fix the
formatting in the first place.

@Dmitry: Maybe give this patch some time (1-2 weeks?) to gather more
feedback,
given the reasons outlined in the cover letter. Also on the driver patch.
OK, I'll hold on to this for a couple of weeks.
Nobody voiced any objections so far, so applied both.
Thanks Dmitry!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help