Re: [PATCH v2 07/16] property: Drop DEVICE_DISABLED flag in fwnode_graph_get_endpoint_count()
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2025-09-24 10:01:15
Also in:
linux-acpi, linux-leds, linux-media, linux-spi, lkml, netdev
On Wed, Sep 24, 2025 at 10:45:53AM +0300, Sakari Ailus wrote:
FWNODE_GRAPH_DEVICE_DISABLED flag isn't used anywhere, drop the flag and support for it in fwnode_graph_get_endpoint_count(). Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
With 06/16 squashed into this, Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
quoted hunk ↗ jump to hunk
--- drivers/base/property.c | 10 ++-------- include/linux/property.h | 8 +------- 2 files changed, 3 insertions(+), 15 deletions(-)diff --git a/drivers/base/property.c b/drivers/base/property.c index 7fc3257f223d..4bd64e729431 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c@@ -1291,21 +1291,15 @@ EXPORT_SYMBOL_GPL(fwnode_graph_get_endpoint_by_id); /** * fwnode_graph_get_endpoint_count - Count endpoints on a device node * @fwnode: The node related to a device - * @flags: fwnode lookup flags * Count endpoints in a device node. - * - * If FWNODE_GRAPH_DEVICE_DISABLED flag is specified, also unconnected endpoints - * and endpoints connected to disabled devices are counted. */ -unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode, - unsigned long flags) +unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode) { struct fwnode_handle *ep; unsigned int count = 0; fwnode_graph_for_each_endpoint(fwnode, ep) { - if (flags & FWNODE_GRAPH_DEVICE_DISABLED || - fwnode_graph_remote_available(ep)) + if (fwnode_graph_remote_available(ep)) count++; }diff --git a/include/linux/property.h b/include/linux/property.h index d1e80b3c9918..8b8bbbe6b5b7 100644 --- a/include/linux/property.h +++ b/include/linux/property.h@@ -503,19 +503,13 @@ static inline bool fwnode_graph_is_endpoint(const struct fwnode_handle *fwnode) * @FWNODE_GRAPH_ENDPOINT_NEXT: In the case of no exact match, look for the * closest endpoint ID greater than the specified * one. - * @FWNODE_GRAPH_DEVICE_DISABLED: That the device to which the remote - * endpoint of the given endpoint belongs to, - * may be disabled, or that the endpoint is not - * connected. */ #define FWNODE_GRAPH_ENDPOINT_NEXT BIT(0) -#define FWNODE_GRAPH_DEVICE_DISABLED BIT(1) struct fwnode_handle * fwnode_graph_get_endpoint_by_id(const struct fwnode_handle *fwnode, u32 port, u32 endpoint, unsigned long flags); -unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode, - unsigned long flags); +unsigned int fwnode_graph_get_endpoint_count(const struct fwnode_handle *fwnode); #define fwnode_graph_for_each_endpoint(fwnode, child) \ for (child = fwnode_graph_get_next_endpoint(fwnode, NULL); child; \
-- Regards, Laurent Pinchart