Re: [PATCH v4 3/5] dt-bindings: touchscreen: convert raspberrypi,firmware-ts bindings to json schema
From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Date: 2025-09-18 21:00:35
Also in:
linux-arm-kernel, linux-devicetree, lkml
On Thu, Sep 18, 2025 at 10:10 PM Rob Herring [off-list ref] wrote:
On Thu, Sep 18, 2025 at 05:36:08PM +0200, Dario Binacchi wrote:quoted
Convert Raspberry Pi firmware 7" touchscreen controller device tree binding to json-schema. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- (no changes since v3) Changes in v3: - Drop firmware-rpi node and use only touchscreen node to fix warnings you can see in https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250913092707.1005616-3-dario.binacchi@amarulasolutions.com/ Changes in v2: - Added in v2 .../touchscreen/raspberrypi,firmware-ts.txt | 26 ------------ .../touchscreen/raspberrypi,firmware-ts.yaml | 40 +++++++++++++++++++ 2 files changed, 40 insertions(+), 26 deletions(-) delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.txt create mode 100644 Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.yamldiff --git a/Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.txt deleted file mode 100644 index 2a1af240ccc3..000000000000 --- a/Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.txt +++ /dev/null@@ -1,26 +0,0 @@ -Raspberry Pi firmware based 7" touchscreen -===================================== - -Required properties: - - compatible: "raspberrypi,firmware-ts" - -Optional properties: - - firmware: Reference to RPi's firmware device node - - touchscreen-size-x: See touchscreen.txt - - touchscreen-size-y: See touchscreen.txt - - touchscreen-inverted-x: See touchscreen.txt - - touchscreen-inverted-y: See touchscreen.txt - - touchscreen-swapped-x-y: See touchscreen.txt - -Example: - -firmware: firmware-rpi { - compatible = "raspberrypi,bcm2835-firmware"; - mboxes = <&mailbox>; - - ts: touchscreen { - compatible = "raspberrypi,firmware-ts"; - touchscreen-size-x = <800>; - touchscreen-size-y = <480>; - }; -};diff --git a/Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.yaml b/Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.yaml new file mode 100644 index 000000000000..697c508326b3 --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.yaml@@ -0,0 +1,40 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/raspberrypi,firmware-ts.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Raspberry Pi firmware based 7" touchscreen + +maintainers: + - Dario Binacchi <dario.binacchi@amarulasolutions.com> + +allOf: + - $ref: touchscreen.yaml# + +properties: + compatible: + enum: + - raspberrypi,firmware-ts + + firmware: + description: Phandle to RPi's firmware device node.deprecated: true It should be a child node.
Should I add the touchscreen node to Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml and remove Documentation/devicetree/bindings/input/touchscreen/raspberrypi,firmware-ts.yaml from this patch? Thanks and regards, Dario
quoted
+ + touchscreen-size-x: true + touchscreen-size-y: true + touchscreen-inverted-x: true + touchscreen-inverted-y: true + touchscreen-swapped-x-y: true + +additionalProperties: false + +required: + - compatible + +examples: + - | + touchscreen { + compatible = "raspberrypi,firmware-ts"; + touchscreen-size-x = <800>; + touchscreen-size-y = <480>; + }; -- 2.43.0 base-commit: 8b789f2b7602a818e7c7488c74414fae21392b63 branch: drop-touchscreen.txt
-- Dario Binacchi Senior Embedded Linux Developer dario.binacchi@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com