[PATCH] hid/usbhid: add reset device for EPROTO
flat view
STALE385d
LANDED
From: zhangjinpeng <hidden>
Date: 2025-09-18 05:55:38
Also in:
linux-usb, lkml
Subsystem:
hid core layer, the rest, usb hid/hidbp drivers (usb keyboards, mice, remote controls, ...) · Maintainers:
Jiri Kosina, Benjamin Tissoires, Linus Torvalds
Landed in mainline as f7812977456c on 2025-11-21.
[ 792.354988] input: PixArt USB Optical Mouse as /devices/platform/PHYT0039:03/usb7/7-1/7-1.2/7-1.2:1.0/0003:093A:2510.0028/input/input53 [ 792.355081] hid-generic 0003:093A:2510.0028: input,hidraw1: USB HID v1.11 Mouse [PixArt USB Optical Mouse] on usb-PHYT0039:03-1.2/input0 [ 792.355137] hub 7-1:1.0: state 7 ports 4 chg 0000 evt 0004 ： xhci-hcd PHYT0039:03: Transfer error for slot 4 ep 2 on endpoint [ 794.579339] xhci-hcd PHYT0039:03: Giveback URB 00000000ab6c1cac, len = 0, expected = 4, status = -71 [ 794.596152] xhci-hcd PHYT0039:03: WARN halted endpoint, queueing URB anyway. [ 917.451251] hub 7-1:1.0: state 7 ports 4 chg 0000 evt 0004 [ 917.451323] usb 7-1-port2: status 0100, change 0001, 12 Mb/s [ 917.451362] usb 7-1-port2: indicator auto status 0 [ 917.451365] usb 7-1.2: USB disconnect, device number 45 [ 917.451367] usb 7-1.2: unregistering device [ 917.451369] usb 7-1.2: unregistering interface 7-1.2:1.0 [ 917.451429] xhci-hcd PHYT0039:03: Cancel URB 00000000ab6c1cac, dev 1.2, ep 0x81, starting at offset 0x2361ea6280 [ 917.451432] xhci-hcd PHYT0039:03: // Ding dong! [ 917.451436] xhci-hcd PHYT0039:03: shutdown urb ffffffa2ebc8e400 ep1in-intr [ 917.451440] xhci-hcd PHYT0039:03: Removing canceled TD starting at 0x2361ea6280 (dma). [ 917.500303] usb 7-1.2: usb_disable_device nuking all URBs [ 917.500310] xhci-hcd PHYT0039:03: xhci_drop_endpoint called for udev 00000000e00ae900 [ 917.500324] xhci-hcd PHYT0039:03: drop ep 0x81, slot id 4, new drop flags = 0x8, new add flags = 0x0 [ 917.500326] xhci-hcd PHYT0039:03: xhci_check_bandwidth called for udev 00000000e00ae900 [ 917.500330] xhci-hcd PHYT0039:03: // Ding dong! [ 917.500351] xhci-hcd PHYT0039:03: Successful Endpoint Configure command [ 917.500579] xhci-hcd PHYT0039:03: // Ding dong! [ 917.656189] usb 7-1-port2: debounce total 100ms stable 100ms status 0x100 Signed-off-by: zhangjinpeng <redacted> --- drivers/hid/usbhid/hid-core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 257dd73e37bf..253f82f33b08 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c@@ -306,8 +306,13 @@ static void hid_irq_in(struct urb *urb) case -ESHUTDOWN: /* unplug */ clear_bit(HID_IN_RUNNING, &usbhid->iofl); return; - case -EILSEQ: /* protocol error or unplug */ case -EPROTO: /* protocol error or unplug */ + usbhid_mark_busy(usbhid); + clear_bit(HID_IN_RUNNING, &usbhid->iofl); + set_bit(HID_CLEAR_HALT, &usbhid->iofl); + usb_queue_reset_device(usbhid->intf); + return; + case -EILSEQ: /* protocol error or unplug */ case -ETIME: /* protocol error or unplug */ case -ETIMEDOUT: /* Should never happen, but... */ usbhid_mark_busy(usbhid);
2.25.1