Krzysztof,

On 8/21/25 3:47 AM, Krzysztof Kozlowski wrote:

On Wed, Aug 20, 2025 at 02:12:50PM -0300, Ariel D'Alessandro wrote:

quoted

Convert the existing text-based DT bindings for Mediatek MT8173 Video Processor
Unit to a YAML schema.

DT schema, not YAML. Don't say YAML at all, neither here nor in subject.

Ack.

Also looks not wrapped...

Ack.

quoted

Signed-off-by: Ariel D'Alessandro <redacted>
---
  .../bindings/media/mediatek,mt8173-vpu.yaml   | 76 +++++++++++++++++++
  .../bindings/media/mediatek-vpu.txt           | 31 --------
  2 files changed, 76 insertions(+), 31 deletions(-)
  create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8173-vpu.yaml
  delete mode 100644 Documentation/devicetree/bindings/media/mediatek-vpu.txt

diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8173-vpu.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8173-vpu.yaml
new file mode 100644
index 0000000000000..44f5d7cc44042
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mt8173-vpu.yaml

@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,mt8173-vpu.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT8173 Video Processor Unit
+
+maintainers:
+  - Ariel D'Alessandro <ariel.dalessandro@collabora.com>
+
+description:
+  Video Processor Unit is a HW video controller. It controls HW Codec including
+  H.264/VP8/VP9 Decode, H.264/VP8 Encode and Image Processor (scale/rotate/color convert).

Please wrap code according to the preferred limit expressed in Kernel
coding style (checkpatch is not a coding style description, but only a
tool).  However don't wrap blindly (see Kernel coding style).

Thanks for the comment. Wrapped to 80 column width.

quoted

+
+properties:
+  compatible:
+    const: mediatek,mt8173-vpu
+
+  reg:
+    minItems: 2

No, from where do you get such syntax?

IIUC, what you mean is s/minItems/maxItems.

quoted

+
+  reg-names:
+    items:
+      - const: tcm
+      - const: cfg_reg
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    items:
+      - const: main
+
+  memory-region:
+    description:
+      phandle to a node describing reserved memory used by VPU
+      (see bindings/reserved-memory/reserved-memory.txt)

Drop, redundant description.

Ack.

Thanks a lot!

-- 
Ariel D'Alessandro
Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK 
Registered in England & Wales, no. 5513718