Re: [PATCH v2 8/9] leds: mc13783: use fsl,led-control as node name
From: Lee Jones <lee@kernel.org>
Date: 2025-09-03 11:59:30
Also in:
linux-devicetree, lkml
Did you actually test this?
According to fsl,mc13xxx.yaml, the node name for led-control is vendor prefixed. Change it accordingly.
According to what, now? I see: % find . -name fsl,mc13xxx.yaml <no results> % git grep fsl,led-control <no results> % git grep led-control | grep -v led-controller Documentation/devicetree/bindings/mfd/mc13xxx.txt: "led-control". Number of register depends of used IC, for MC13783 is 6, Documentation/devicetree/bindings/mfd/mc13xxx.txt: led-control = <0x000 0x000 0x0e0 0x000>; Documentation/netlink/specs/rt-link.yaml: name: coupled-control arch/arm/boot/dts/nxp/imx/imx27-phytec-phycore-som.dtsi: led-control = <0x001 0x000 0x000 0x000 0x000 0x000>; arch/arm/boot/dts/nxp/imx/imx51-zii-rdu1.dts: led-control = <0x0 0x0 0x3f83f8 0x0>; arch/arm/boot/dts/nxp/imx/imx51-zii-scu2-mezz.dts: led-control = <0x0 0x0 0x3f83f8 0x0>; arch/arm/boot/dts/nxp/imx/imx51-zii-scu3-esb.dts: led-control = <0x0 0x0 0x3f83f8 0x0>; drivers/leds/leds-mc13783.c: ret = of_property_read_u32_array(parent, "led-control",
quoted hunk ↗ jump to hunk
Signed-off-by: Alexander Kurz <redacted> --- drivers/leds/leds-mc13783.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c index e22f09d13798..11add1fd24ce 100644 --- a/drivers/leds/leds-mc13783.c +++ b/drivers/leds/leds-mc13783.c@@ -127,7 +127,7 @@ static struct mc13xxx_leds_platform_data __init *mc13xxx_led_probe_dt( if (!parent) return ERR_PTR(-ENODATA); - ret = of_property_read_u32_array(parent, "led-control", + ret = of_property_read_u32_array(parent, "fsl,led-control", pdata->led_control, leds->devtype->num_regs);
-- Lee Jones [李琼斯]