On Aug 12 2025, Cheng, Ping wrote:

Hi Jiri,

Please revert this patchset since I need help from Benjamin to make the selftest real. Patch 2 does not do its job...

Furthermore:
  CC      drivers/hid/hid-input.o
drivers/hid/hid-input.c: In function 'hidinput_configure_usage':
drivers/hid/hid-input.c:863:28: error: this statement may fall through [-Werror=implicit-fallthrough=]
  863 |                         if ((field->application & 0xff) == 0x02) {
      |                            ^
drivers/hid/hid-input.c:872:17: note: here
  872 |                 case HID_GD_X: case HID_GD_Y:
      |                 ^~~~

So this breaks compilation entirely :(

[Sorry I'm just back from vacations, and hadn't had the time to look at
the pile of emails]

Cheers,
Benjamin

Thank you for your effort. And sorry for the trouble.
Ping

________________________________________
From: Jiri Kosina <jikos@kernel.org>
Sent: Tuesday, August 12, 2025 5:35 AM
To: Ping Cheng <redacted>
Cc: linux-input@vger.kernel.org <redacted>; bentiss@kernel.org <bentiss@kernel.org>; Dmitry.Torokhov@gmail.com <Dmitry.Torokhov@gmail.com>; stable@kernel.org <stable@kernel.org>; Cheng, Ping <Ping.Cheng@wacom.com>
Subject: Re: [PATCH 1/2] HID: input: map HID_GD_Z to ABS_DISTANCE for stylus/pen

Both applied to hid.git#for-6.18/core, thanks.

--
Jiri Kosina
SUSE Labs