Re: [PATCH v4 2/2] platform/x86: asus-wmi: Refactor Ally suspend/resume
From: Jiri Slaby <jirislaby@kernel.org>
Date: 2025-08-20 03:47:13
Also in:
lkml, platform-driver-x86
On 23. 03. 25, 3:34, Luke Jones wrote:
From: "Luke D. Jones" <luke@ljones.dev> Adjust how the CSEE direct call hack is used. The results of months of testing combined with help from ASUS to determine the actual cause of suspend issues has resulted in this refactoring which immensely improves the reliability for devices which do not have the following minimum MCU FW version: - ROG Ally X: 313 - ROG Ally 1: 319
...
quoted hunk ↗ jump to hunk
--- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c
...
quoted hunk ↗ jump to hunk
@@ -5010,6 +5060,10 @@ static int asus_wmi_probe(struct platform_device *pdev) return ret; } + ret = acpi_register_lps0_dev(&asus_ally_s2idle_dev_ops);
This likely causes crashes: https://bugzilla.suse.com/show_bug.cgi?id=1246924 > asus-nb-wmi asus-nb-wmi: Detected ATK, not ASUSWMI, use DSTS > list_add double add: new=ffffffffc2094460, prev=ffffffffafa5cd20, next=ffffffffc2094460. > ------------[ cut here ]------------ > kernel BUG at lib/list_debug.c:35! ... > acpi_register_lps0_dev.cold (include/linux/list.h:88 include/linux/list.h:150 include/linux/list.h:169 drivers/acpi/x86/s2idle.c:663) > asus_wmi_probe (drivers/platform/x86/asus-wmi.c:5045 (discriminator 1) drivers/platform/x86/asus-wmi.c:5089 (discriminator 1)) asus_wmi > platform_probe (drivers/base/platform.c:1404) > really_probe (drivers/base/dd.c:579) It looks like acpi_register_lps0_dev() is called twice with those ops... Should the above be registered only if it is this RC71 device? thanks, -- js suse labs