Re: [PATCH v1 1/2] dt-bindings: HID: i2c-hid: parade: Introduce bindings for Parade tc3408
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-08-19 07:00:56
Also in:
linux-devicetree, lkml
On Tue, Aug 19, 2025 at 11:48:51AM +0800, Langyan Ye wrote:
The tc3408 touch screen chip same as Elan eKTH6915 controller has a reset gpio. The difference is that they have different post_power_delay_ms. Signed-off-by: Langyan Ye <redacted>
A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Just "Add foo bar"
quoted hunk ↗ jump to hunk
--- .../bindings/input/parade,tc3408.yaml | 72 +++++++++++++++++++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/parade,tc3408.yamldiff --git a/Documentation/devicetree/bindings/input/parade,tc3408.yaml b/Documentation/devicetree/bindings/input/parade,tc3408.yaml new file mode 100644 index 000000000000..25db85e90b18 --- /dev/null +++ b/Documentation/devicetree/bindings/input/parade,tc3408.yaml@@ -0,0 +1,72 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/parade,tc3408.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Parade tc3408 touchscreen controller + +maintainers: + - Langyan Ye <yelangyan@huaqin.corp-partner.google.com> + +description: + Supports the Parade tc3408 touchscreen controller.
Describe the hardware, not what binding supports. You just repeated title, BTW.
+ This touchscreen controller uses the i2c-hid protocol with a reset GPIO. + +allOf: + - $ref: /schemas/input/touchscreen/touchscreen.yaml# + +properties: + compatible: + const: parade,tc3408 + + reg: + const: 0x24 + + interrupts: + maxItems: 1 + + panel: true
Drop
+ + reset-gpios: + maxItems: 1 + description: Reset GPIO.
Drop description, redundant.
+ + vcc33-supply: + description: The 3.3V supply to the touchscreen. + + vccio-supply: + description: The 1.8V supply to the touchscreen. + +required: + - compatible + - reg + - interrupts + - panel + - vcc33-supply + - vccio-supply + +additionalProperties: false
unevaluatedProperties instead Best regards, Krzysztof