On Tue, Aug 12, 2025 at 06:06:53PM +0200, Jihed Chaibi wrote:

On Tue, Aug 12, 2025 at 4:54 PM Rob Herring [off-list ref] wrote:

quoted

On Mon, Aug 11, 2025 at 08:24:43PM -0500, Rob Herring (Arm) wrote:

quoted

On Tue, 12 Aug 2025 00:47:33 +0200, Jihed Chaibi wrote:

quoted

Convert the legacy TXT binding for the TWL6040 MFD
to the modern YAML DT schema format. This adds formal validation
and improves documentation.

Signed-off-by: Jihed Chaibi <redacted>
---
 .../devicetree/bindings/mfd/ti,twl6040.yaml   | 155 ++++++++++++++++++
 .../devicetree/bindings/mfd/twl6040.txt       |  67 --------
 2 files changed, 155 insertions(+), 67 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,twl6040.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/twl6040.txt

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,twl6040.example.dtb:
twl@4b (ti,twl6040): 'twl6040,audpwron-gpio' does not match any of
the regexes: '^#.*',
'^(at25|bm|devbus|dmacap|dsa|exynos|fsi[ab]|gpio-fan|gpio-key|gpio|gpmc|hdmi|i2c-gpio),.*',
'^(keypad|m25p|max8952|max8997|max8998|mpmc),.*',
'^(pciclass|pinctrl-single|#pinctrl-single|PowerPC),.*',
'^(pl022|pxa-mmc|rcar_sound|rotary-encoder|s5m8767|sdhci),.*',
'^(simple-audio-card|st-plgpio|st-spics|ts),.*',

You will need to add 'twl6040' to this list of exceptions in
vendor-prefixes.yaml.

Rob

Hi Rob, thanks for the feedback.

Wouldn't it be simpler if we put 'ti' (the actual vendor) instead of 'twl6040'?
No other file is using the current name, so there would be no need for
additional editing.

Indeed. Actually, just drop the property because the driver doesn't use 
it either. Just note the change in the commit msg.

Rob