[PATCH v2] HID: hid-ntrig: fix unable to handle page fault in ntrig_report_version()
From: Minjong Kim <hidden>
Date: 2025-08-13 10:30:55
Also in:
lkml
Subsystem:
hid core layer, the rest · Maintainers:
Jiri Kosina, Benjamin Tissoires, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2025-08-13 · Re: [PATCH v2] HID: hid-ntrig: fix unable to handle page fault in ntrig_report_version() · Benjamin Tissoires <bentiss@kernel.org>
- 2025-08-13 · Re: [PATCH v2] HID: hid-ntrig: fix unable to handle page fault in ntrig_report_version() · Minjong Kim <hidden>
in ntrig_report_version(), hdev parameter passed from hid_probe(). sending descriptor to /dev/uhid can make hdev->dev.parent->parent to null if hdev->dev.parent->parent is null, usb_dev has invalid address(0xffffffffffffff58) that hid_to_usb_dev(hdev) returned when usb_rcvctrlpipe() use usb_dev,it trigger page fault error for address(0xffffffffffffff58) add null check logic to ntrig_report_version() before calling hid_to_usb_dev() Signed-off-by: Minjong Kim <redacted> --- drivers/hid/hid-ntrig.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
index 2738ce947434f904f32e9a1979b1681c66972ff9..0f76e241e0afb4adb38885a008a05edb24169ea9 100644
--- a/drivers/hid/hid-ntrig.c
+++ b/drivers/hid/hid-ntrig.c@@ -144,6 +144,9 @@ static void ntrig_report_version(struct hid_device *hdev) struct usb_device *usb_dev = hid_to_usb_dev(hdev); unsigned char *data = kmalloc(8, GFP_KERNEL); + if (!hid_is_usb(hdev)) + return; + if (!data) goto err_free; ---
base-commit: 347e9f5043c89695b01e66b3ed111755afcf1911 change-id: 20250717-hid-ntrig-page-fault-fix-d13c49c86473 Best regards, -- Minjong Kim [off-list ref]