Re: [PATCH] HID: amd_sfh: Enable operating mode

On 6/13/25 21:46, Mario Limonciello wrote:

On 6/9/2025 3:21 PM, Mario Limonciello wrote:

quoted

+Denis

On 5/27/2025 4:10 AM, Basavaraj Natikar wrote:

quoted

Add changes to enable operating modes in the driver to allow the FW to
activate and retrieve data from relevant sensors. This enables the FW to
take necessary actions based on the operating modes.

Co-developed-by: Akshata MukundShetty <redacted>
Signed-off-by: Akshata MukundShetty <redacted>
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

Comparing this to the series that was submitted by Denis [1] I notice that the main tangible difference is that this isn't exported into the HID descriptor.  So how does userspace know the current operating mode with this patch?

Link: https://lore.kernel.org/linux-input/20250309194934.1759953-2- benato.denis96@gmail.com/ [1]

Recently a bug report came in: https://bugzilla.kernel.org/show_bug.cgi?id=220224

It was very weird because it advertised a tablet mode switch which I believe comes from the patch that I linked being added to a downstream kernel.  So there appears to be problems with the descriptor from that patch.

Considering this, I think what you're doing is fine for now; appears firmware is notified on tablet mode.

Unfortunately this version of the patch is also causing problems for the user above. Attached is their journal log with the kernel traces. See [1] for the GitHub issue.

-- 
Regards,
  Eric

[1] https://github.com/CachyOS/linux-cachyos/issues/483