Re: [PATCH 1/4] dt-bindings: input: adc-keys: allow linux,input-type property
From: Heiko Stübner <heiko@sntech.de>
Date: 2025-06-30 11:37:37
Also in:
linux-arm-kernel, linux-devicetree, linux-rockchip, lkml
Am Montag, 30. Juni 2025, 12:19:24 Mitteleuropäische Sommerzeit schrieb Nicolas Frattaroli:
quoted hunk ↗ jump to hunk
adc-keys, unlike gpio-keys, does not allow linux,input-type as a valid property. This makes it impossible to model devices that have ADC inputs that should generate switch events. Add the property to the binding with the same default as gpio-keys. Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com> --- Documentation/devicetree/bindings/input/adc-keys.yaml | 3 +++ 1 file changed, 3 insertions(+)diff --git a/Documentation/devicetree/bindings/input/adc-keys.yaml b/Documentation/devicetree/bindings/input/adc-keys.yaml index 7aa078dead37816294732501e1983ab869f38311..e372ebc23d1651d73ef3749a56d54872067037b5 100644 --- a/Documentation/devicetree/bindings/input/adc-keys.yaml +++ b/Documentation/devicetree/bindings/input/adc-keys.yaml@@ -42,6 +42,9 @@ patternProperties: linux,code: true + linux,input-type: + default: 1 # EV_KEY +
having both adc- and gpio-keys behave the same in that regard makes a lot of sense, and the addition matches gpio-keys.yaml, so Reviewed-by: Heiko Stuebner <heiko@sntech.de>
press-threshold-microvolt:
description:
Voltage above or equal to which this key is considered pressed. No