Thread (53 messages) 53 messages, 5 authors, 2025-06-27

Re: [PATCH v3 2/4] gpiolib: acpi: Program debounce when finding GPIO

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2025-06-26 14:31:27
Also in: linux-acpi, linux-gpio, lkml

On Wed, Jun 25, 2025 at 04:58:11PM -0500, Mario Limonciello wrote:
From: Mario Limonciello <mario.limonciello@amd.com>

When soc-button-array looks up the GPIO to use it calls acpi_find_gpio()
which will parse _CRS.

acpi_find_gpio.cold (drivers/gpio/gpiolib-acpi-core.c:953)
gpiod_find_and_request (drivers/gpio/gpiolib.c:4598 drivers/gpio/gpiolib.c:4625)
gpiod_get_index (drivers/gpio/gpiolib.c:4877)

The GPIO is setup basically, but the debounce information is discarded.
The platform will assert what debounce should be in _CRS, so program it
at the time it's available.
No objections, just a style nit-pick.

...
 	acpi_gpio_update_gpiod_flags(dflags, &info);
 	acpi_gpio_update_gpiod_lookup_flags(lookupflags, &info);
+ blank line
+	acpi_set_debounce_timeout(desc, info.debounce);
+ blank line (this one I'm not sure, need to check the other function style).
 	return desc;
-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help