Re: [PATCH 1/2] dt-bindings: input: goodix,gt9916: Document stylus support
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-06-05 05:54:14
Also in:
linux-devicetree, lkml
On 05/06/2025 07:48, Pengyu Luo wrote:
quoted hunk ↗ jump to hunk
Document stylus support. Optional support for DT properties: - `goodix,stylus-enable` - `goodix,stylus-pressure-level` - `goodix,physical-x` - `goodix,physical-y` Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com> --- .../input/touchscreen/goodix,gt9916.yaml | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+)diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml b/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml index c40d92b7f..e5476ea36 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix,gt9916.yaml@@ -44,6 +44,27 @@ properties: touchscreen-size-y: true touchscreen-swapped-x-y: true + goodix,stylus-enable: + type: boolean + description: + Indicates that stylus (pen) functionality is enabled. If present,
Looks like deducible from the compatible.
+ the driver will initialize stylus-specific input reporting.
What if my driver does something else? Shall we change the binding? No.
+ + goodix,physical-x: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Physical width of the touchscreen in millimeters.
No, use existing input properties.
+ + goodix,physical-y: + $ref: /schemas/types.yaml#/definitions/uint32 + description: Physical height of the touchscreen in millimeters. + + goodix,stylus-pressure-level: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + Number of discrete pressure levels supported by the stylus. + The reported ABS_PRESSURE range will be 0 to + (goodix,stylus-pressure-level - 1).
Use existing input properties. Best regards, Krzysztof