Re: [PATCH RESEND] HID: thrustmaster: fix memory leak in thrustmaster_interrupts()
From: Markus Elfring <hidden>
Date: 2025-04-07 11:38:38
Also in:
linux-arm-kernel, lkml
In thrustmaster_interrupts(), the allocated send_buf is not freed if the usb_check_int_endpoints() check fails, leading to a memory leak.
Will you get into the mood to make word wrapping occasionally a bit nicer for such text lines (which may be longer than 59 characters)? …
quoted hunk ↗ jump to hunk
+++ b/drivers/hid/hid-thrustmaster.c@@ -174,6 +174,7 @@ static void thrustmaster_interrupts(struct hid_device *hdev) u8 ep_addr[2] = {b_ep, 0}; if (!usb_check_int_endpoints(usbif, ep_addr)) { + kfree(send_buf); hid_err(hdev, "Unexpected non-int endpoint\n"); return; }
* You may avoid such repeated function calls by using another label instead. https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources#MEM12C.Considerusingagotochainwhenleavingafunctiononerrorwhenusingandreleasingresources-CompliantSolution(copy_process()fromLinuxkernel) * How do you think about to benefit any more from the application of the attribute “__free”? https://elixir.bootlin.com/linux/v6.14-rc6/source/include/linux/slab.h#L472 Regards, Markus