Re: [PATCH v3 4/7] dt-bindings: input: matrix_keypad - add missing property
flat view
From: Rob Herring <robh@kernel.org>
Date: 2025-01-07 19:27:02
Also in:
linux-devicetree, lkml
On Tue, Jan 07, 2025 at 02:56:56PM +0100, Markus Burri wrote:
quoted hunk ↗ jump to hunk
The property is implemented in the driver but not described in dt-bindings. Add missing property 'gpio-activelow' to DT schema. Signed-off-by: Markus Burri <redacted> --- .../devicetree/bindings/input/gpio-matrix-keypad.yaml | 3 +++ 1 file changed, 3 insertions(+)diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml index 75975a1..b10da65 100644 --- a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml +++ b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.yaml@@ -38,6 +38,9 @@ properties: type: boolean description: Do not enable autorepeat feature. + gpio-activelow: + type: boolean + description: The GPIOs are low active.
Ideally this should be defined correctly in the gpio properties. The problem is that does a 0 flag value mean active high or I forgot to define it. There's a similar issue in spi-controller.yaml. I *think* the problem is better here since this is an active low boolean rather than an active high boolean. Of the users in the kernel tree, only arch/arm/boot/dts/ti/omap/am335x-guardian.dts got this right. So I think we should mark this deprecated and put a note to use GPIO flags instead. Rob