Thread (3 messages) 3 messages, 3 authors, 2024-12-15

Re: [PATCH v2] iio: hid-sensor-prox: Fix invalid read_raw for attention

From: Jonathan Cameron <jic23@kernel.org>
Date: 2024-12-15 12:58:06
Also in: linux-iio, lkml

On Fri, 22 Nov 2024 09:55:04 -0800
srinivas pandruvada [off-list ref] wrote:
On Fri, 2024-11-22 at 17:36 +0000, Ricardo Ribalda wrote:
quoted
The attention channel is a IIO_CHAN_INFO_PROCESSED, not a
IIO_CHAN_INFO_RAW.

Modify prox_read_raw() to support it.

Fixes: 596ef5cf654b ("iio: hid-sensor-prox: Add support for more
channels")
Signed-off-by: Ricardo Ribalda <redacted>  
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan
quoted
---
Changes in v2:
- Do not change the condition for applying the multiplier.
- Link to v1:
https://lore.kernel.org/r/20241121-fix-processed-v1-1-4fae6770db30@chromium.org (local)
---
 drivers/iio/light/hid-sensor-prox.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/iio/light/hid-sensor-prox.c
b/drivers/iio/light/hid-sensor-prox.c
index e8e7b2999b4c..0daa8d365a6c 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -94,6 +94,7 @@ static int prox_read_raw(struct iio_dev *indio_dev,
 	*val2 = 0;
 	switch (mask) {
 	case IIO_CHAN_INFO_RAW:
+	case IIO_CHAN_INFO_PROCESSED:
 		if (chan->scan_index >= prox_state->num_channels)
 			return -EINVAL;
 		address = prox_state->channel2usage[chan-  
quoted
scan_index];  
---
base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
change-id: 20241121-fix-processed-ed1a95641e64

Best regards,  
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help