Re: [PATCH v1 4/6] pcmcia: soc_common: Avoid using GPIOF_ACTIVE_LOW

Linus Walleij · 2024-11-08T09:28:19+0100

On Mon, Nov 4, 2024 at 10:36 AM Andy Shevchenko wrote: > Avoid using GPIOF_ACTIVE_LOW as it's deprecated and subject to remove. > > Signed-off-by: Andy Shevchenko Looks right to me, some testing would be even better because I never trust these flags to get right. Reviewed-by: Linus Walleij Yours, Linus Walleij

[PATCH v1 0/6] gpio: Get rid of deprecated GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-04
[PATCH v1 1/6] Input: gpio_keys - avoid using GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-04
Re: [PATCH v1 1/6] Input: gpio_keys - avoid using GPIOF_ACTIVE_LOW · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-11-05
Re: [PATCH v1 1/6] Input: gpio_keys - avoid using GPIOF_ACTIVE_LOW · Linus Walleij <hidden> · 2024-11-08
[PATCH v1 2/6] Input: gpio_keys_polled - avoid using GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-04
Re: [PATCH v1 2/6] Input: gpio_keys_polled - avoid using GPIOF_ACTIVE_LOW · Dmitry Torokhov <dmitry.torokhov@gmail.com> · 2024-11-05
Re: [PATCH v1 2/6] Input: gpio_keys_polled - avoid using GPIOF_ACTIVE_LOW · Linus Walleij <hidden> · 2024-11-08
[PATCH v1 4/6] pcmcia: soc_common: Avoid using GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-04
Re: [PATCH v1 4/6] pcmcia: soc_common: Avoid using GPIOF_ACTIVE_LOW · Linus Walleij <hidden> · 2024-11-08
Re: [PATCH v1 4/6] pcmcia: soc_common: Avoid using GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-08
Re: [PATCH v1 4/6] pcmcia: soc_common: Avoid using GPIOF_ACTIVE_LOW · Dominik Brodowski <linux@dominikbrodowski.net> · 2024-11-09
Re: [PATCH v1 4/6] pcmcia: soc_common: Avoid using GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-11
[PATCH v1 3/6] leds: gpio: Avoid using GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-04
Re: [PATCH v1 3/6] leds: gpio: Avoid using GPIOF_ACTIVE_LOW · Lee Jones <lee@kernel.org> · 2024-11-06
Re: [PATCH v1 3/6] leds: gpio: Avoid using GPIOF_ACTIVE_LOW · Linus Walleij <hidden> · 2024-11-08
Re: [PATCH v1 3/6] leds: gpio: Avoid using GPIOF_ACTIVE_LOW · Geert Uytterhoeven <geert@linux-m68k.org> · 2024-11-11
Re: [PATCH v1 3/6] leds: gpio: Avoid using GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-11
Re: [PATCH v1 3/6] leds: gpio: Avoid using GPIOF_ACTIVE_LOW · Geert Uytterhoeven <geert@linux-m68k.org> · 2024-11-11
[PATCH v1 6/6] gpio: Get rid of GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-04
Re: [PATCH v1 6/6] gpio: Get rid of GPIOF_ACTIVE_LOW · Linus Walleij <hidden> · 2024-11-08
[PATCH v1 5/6] USB: gadget: pxa27x_udc: Avoid using GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-04
Re: [PATCH v1 5/6] USB: gadget: pxa27x_udc: Avoid using GPIOF_ACTIVE_LOW · Greg Kroah-Hartman <gregkh@linuxfoundation.org> · 2024-11-05
Re: [PATCH v1 5/6] USB: gadget: pxa27x_udc: Avoid using GPIOF_ACTIVE_LOW · Linus Walleij <hidden> · 2024-11-08
Re: [PATCH v1 0/6] gpio: Get rid of deprecated GPIOF_ACTIVE_LOW · Andy Shevchenko <andriy.shevchenko@linux.intel.com> · 2024-11-06
Re: [PATCH v1 0/6] gpio: Get rid of deprecated GPIOF_ACTIVE_LOW · Bartosz Golaszewski <hidden> · 2024-11-06
Re: [PATCH v1 0/6] gpio: Get rid of deprecated GPIOF_ACTIVE_LOW · Bartosz Golaszewski <hidden> · 2024-11-09

From: Linus Walleij <hidden>
Date: 2024-11-08 08:28:32
Also in: linux-arm-kernel, linux-gpio, linux-leds, linux-usb, lkml

On Mon, Nov 4, 2024 at 10:36 AM Andy Shevchenko
[off-list ref] wrote:

Avoid using GPIOF_ACTIVE_LOW as it's deprecated and subject to remove.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Looks right to me, some testing would be even better
because I never trust these flags to get right.

Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help