Re: [PATCH v2] HID: wacom: Hardcode (non-inverted) AES pens as BTN_TOOL_PEN

From
Jiri Kosina <jikos@kernel.org>
Date
2024-10-11 09:12:59
Also in
stable
Reply to
Gerecke, Jason, 2024-10-09
On Wed, 9 Oct 2024, Gerecke, Jason wrote:
From: Jason Gerecke <jason.gerecke@wacom.com>

Unlike EMR tools which encode type information in their tool ID, tools
for AES sensors are all "generic pens". It is inappropriate to make use
of the wacom_intuos_get_tool_type function when dealing with these kinds
of devices. Instead, we should only ever report BTN_TOOL_PEN or
BTN_TOOL_RUBBER, as depending on the state of the Eraser and Invert
bits.

Reported-by: Daniel Jutz <redacted>
Closes: https://lore.kernel.org/linux-input/3cd82004-c5b8-4f2a-9a3b-d88d855c65e4@heusel.eu/ (local)
Bisected-by: Christian Heusel [off-list ref]
Fixes: 9c2913b962da ("HID: wacom: more appropriate tool type categorization")
Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/1041
Link: https://github.com/linuxwacom/input-wacom/issues/440
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Cc: <redacted>
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Applied, thanks Jason.

-- 
Jiri Kosina
SUSE Labs
Thread (2 messages) 2 messages, 2 authors, last reply 2024-10-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help