Thread (11 messages) 11 messages, 4 authors, 2024-08-15

Re: [PATCH 1/1] dt-bindings: input: touchscreen: convert ads7846.txt to yaml

From: Frank Li <Frank.li@nxp.com>
Date: 2024-08-15 20:29:39
Also in: imx, linux-devicetree, lkml

On Thu, Aug 15, 2024 at 11:26:38AM -0400, Frank Li wrote:
On Thu, Aug 15, 2024 at 09:17:48AM -0600, Rob Herring wrote:
quoted
On Wed, Aug 14, 2024 at 8:01 PM Frank Li [off-list ref] wrote:
quoted
On Wed, Aug 14, 2024 at 03:49:02PM -0600, Rob Herring wrote:
quoted
On Wed, Aug 14, 2024 at 03:13:45PM -0600, Rob Herring wrote:
quoted
On Wed, Aug 14, 2024 at 02:51:35PM -0400, Frank Li wrote:
quoted
Convert binding doc ads7846.txt to yaml format.
Additional change:
- add ref to touchscreen.yaml and spi-peripheral-props.yaml.
- use common node name touchscreen.

Fix below warning: arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb: touchscreen@0:
  ti,x-min: b'\x00}' is not of type 'object', 'array', 'boolean', 'null'

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
There are warning:
Documentation/devicetree/bindings/input/touchscreen/ti,ads7843.yaml: properties:ti,x-plate-ohms: '$ref' should not be valid under {'const': '$ref'}
  hint: Standard unit suffix properties don't need a type $ref

I don't know how to fix it. ti,x-plate-ohms is 16bit, but default it is
uint32
It's going to have to be a special case in dtschema. I'll work on a fix.
Should be fixed now in dtschema main branch.
Strange, dt_binding_check can pass. but

 make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y imx8mm-var-som-symphony.dtb
  UPD     include/config/kernel.release
  DTC [C] arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dtb: touchscreen@0: ti,x-plate-ohms: 180 is not of type 'array'
        from schema $id: http://devicetree.org/schemas/property-units.yaml#

anything wrong?
Now fixed.
Yes, thanks.
A new error in dt_binding_check

Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml: ti,x-plate-ohms: missing type definition
Frank
quoted
Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help