Re: [PATCH] Input: ads7846 - add dummy command register clearing cycle
From: Aaro Koskinen <aaro.koskinen@iki.fi>
Date: 2024-06-26 22:33:35
Hi, On Wed, Jun 26, 2024 at 02:40:00PM +0200, Linus Walleij wrote:
On Tue, Jun 25, 2024 at 10:50 PM Dmitry Torokhov [off-list ref] wrote:quoted
I am concerned that we are putting workaroud for a single controller into common function. Can we quirk it based on compatible? If not then I would like someone to run tests on other controllers. Unfortunately I do not have such hardware. Linus, do you have devices with ads7846 or tsc2046 by chance? Spitz?Sadly I do not, but it is inside the Nokia770 so maybe Aaro can test it? (Not sure if Aaro has the 770 though...)
I sure have 770, and I can test patches. However, ads7846 has regressed and it has been broken on 770 for a couple years already as half-duplex support got suddenly deleted without any pre-warning to users (770 was using this driver maybe a decade without any issues). I reported this as a regression but input maintainers preferred to prioritize "nicer hardware". See e.g.: https://marc.info/?l=linux-input&m=164783764828520&w=2 I'm planning to restore the half-duplex support for 770, but it's not on my top prioriority list so it will take a while. Meanwhile, maybe you can ask the users of such "nicer hardware" to test. A.