Thread (2 messages) 2 messages, 2 authors, 2024-06-09

Re: [PATCH] Input: touchscreen - use sizeof(*pointer) instead of sizeof(type)

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2024-06-09 21:41:11
Also in: linux-hardening, lkml

On Sat, Jun 08, 2024 at 04:34:49PM +0200, Erick Archer wrote:
It is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not
change the former (unlike the latter).

The refactoring is mostly trivial except for "usbtouchscreen.c"
file. Here, in the "mtouch_alloc" and "nexio_alloc" functions,
it is necessary to use a variable with a predefined type instead
of the "usbtouch->priv" variable (void * type). This way, the
"sizeof" operator can now know the correct size. Moreover, we
need to set the "usbtouch->priv" pointer after the memory
allocation since now the "kmalloc" return value is not assigned
directly.

This patch has no effect on runtime behavior.

Signed-off-by: Erick Archer <redacted>
Applied, thank you.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help