Thread (4 messages) 4 messages, 3 authors, 2024-05-24

Re: [PATCH] HID: usbhid: enable remote wakeup for mouse

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2024-05-22 11:23:48
Also in: linux-usb, lkml

On Wed, May 22, 2024 at 05:22:57PM +0800, huanglei814 wrote:
From: huanglei <redacted>

This patch enables remote wakeup by default for USB mouse
devices.
That is not a good idea.  Please see the mailing list archives for the
past 20+ years for why this is the way it is.

If you know your device can support this, please set it in userspace,
but we can not change the default value at this point in time, sorry.
Mouse can used to be wakeup devices, but the correct
place to enable it depends on the device's bus; no single
approach will work for all mouse devices.  In particular, this
covers only USB mouse (and then only those supporting the boot
protocol).
And that is really not a wise choice, boot protocol mice have no
requirement that they support remote wakeup.  So restricting it like
this really will not help, sorry.

Again, do this in userspace, that's why the interface is there to do so.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help