RE: [PATCH 4/4] platform: chrome: cros_ec_ishtp: use helper functions for connection

Thanks Jiri!

Best Regards,
Even Xu

-----Original Message-----
From: Jiri Kosina <redacted> 
Sent: Wednesday, December 6, 2023 6:34 PM
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Xu, Even <even.xu@intel.com>; srinivas.pandruvada@linux.intel.com; bleung@chromium.org; groeck@chromium.org; linux-input@vger.kernel.org; chrome-platform@lists.linux.dev
Subject: Re: [PATCH 4/4] platform: chrome: cros_ec_ishtp: use helper functions for connection

On Wed, 6 Dec 2023, Tzung-Bi Shih wrote:

On Tue, Dec 05, 2023 at 09:50:33AM +0800, Even Xu wrote:

quoted

Use helper functions ishtp_cl_establish_connection() and
ishtp_cl_destroy_connection() to establish and destroy connection 
respectively. These functions are used during initialization, reset 
and deinitialization flows.

No functional changes are expected.

Signed-off-by: Even Xu <even.xu@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

Acked-by: Tzung-Bi Shih <tzungbi@kernel.org>

Thanks.

One minor suggestion: we usually use "platform/chrome:" instead of
"platform: chrome:" for the title prefix.

I have changed that, and am taking it together with the rest of the series through hid.git#for-6.8/intel-ish.

--
Jiri Kosina
SUSE Labs