Re: [PATCH v5 8/8] dt-bindings: mfd: dlg,da9063: Convert da9062 to json-schema

From
Conor Dooley <conor@kernel.org>
Date
2023-12-12 16:54:23
Also in
linux-devicetree, linux-pm, linux-renesas-soc
Reply to
Biju Das, 2023-12-11
On Mon, Dec 11, 2023 at 06:51:14PM +0000, Biju Das wrote:
Hi Conor Dooley,

Thanks for the feedback.
quoted
-----Original Message-----
From: Conor Dooley <conor@kernel.org>
Sent: Monday, December 11, 2023 6:38 PM
Subject: Re: [PATCH v5 8/8] dt-bindings: mfd: dlg,da9063: Convert da9062
to json-schema

On Sun, Dec 10, 2023 at 01:47:17PM +0000, Biju Das wrote:
quoted
Convert the da9062 PMIC device tree binding documentation to json-
schema.
quoted
Document the missing gpio child node for da9062.

While at it, update description with link to product information and
example.

The missing child node with of_compatible defined in MFD_CELL_OF is
causing the below warning message:
da9062-gpio: Failed to locate of_node [id: -1]

So, make all child nodes with of_compatible defined in struct mfd_cell
as required property for da906{1,2} devices.
quoted
+  gpio-controller: true
+
+  "#gpio-cells":
+    const: 2
+
+  gpio:
+    type: object
+    additionalProperties: false
+    properties:
+      compatible:
+        const: dlg,da9062-gpio
quoted
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/regulator/dlg,da9063-regulator.h>
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      pmic@58 {
+        compatible = "dlg,da9062";
+        reg = <0x58>;
+        gpio-controller;
+        #gpio-cells = <2>;
quoted
+        gpio {
+          compatible = "dlg,da9062-gpio";
+        };
I know you had some conversation with Krzysztof, but I still don;t really
follow this. Why is the parent, rather than the child, the one that gets
the "gpio-controller" and "#gpio-cells" properties? The commit message
just mentions why missing child node was added, but not the reason for the
gpio properties being added at what appears to be the "wrong" level.

Please see [1], The driver is checking against parent "gpio-controller"

[1] https://elixir.bootlin.com/linux/v6.0-rc4/source/drivers/pinctrl/pinctrl-da9062.c#L270
I would appreciate if you could note in your commit message the
rationale behind the strange setup. Citing the existing driver users etc
would be helpful.

Thanks,
Conor.

Attachments

Thread (9 messages) 9 messages, 3 authors, last reply 2023-12-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help