Thread (10 messages) 10 messages, 2 authors, 2023-10-11

Re: [PATCH RFT v8 2/6] ARM: pxa: Convert Spitz LEDs to GPIO descriptors

From: Bartosz Golaszewski <hidden>
Date: 2023-10-11 14:21:56
Also in: linux-arm-kernel, linux-gpio, linux-spi, linux-usb, lkml

On Wed, Oct 11, 2023 at 3:24 PM Duje Mihanović [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Sharp's Spitz board still uses the legacy GPIO interface for configuring
its two onboard LEDs.

Convert them to use the GPIO descriptor interface.

Reviewed-by: Linus Walleij <redacted>
Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
---
 arch/arm/mach-pxa/spitz.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-pxa/spitz.c b/arch/arm/mach-pxa/spitz.c
index 535e2b2e997b..9efd603c715a 100644
--- a/arch/arm/mach-pxa/spitz.c
+++ b/arch/arm/mach-pxa/spitz.c
@@ -452,16 +452,25 @@ static inline void spitz_keys_init(void) {}
  * LEDs
  ******************************************************************************/
 #if defined(CONFIG_LEDS_GPIO) || defined(CONFIG_LEDS_GPIO_MODULE)
+static struct gpiod_lookup_table spitz_led_gpio_table = {
+       .dev_id = "leds-gpio",
+       .table = {
+               GPIO_LOOKUP_IDX("pxa-gpio", SPITZ_GPIO_LED_ORANGE, NULL, 0,
+                               GPIO_ACTIVE_HIGH),
+               GPIO_LOOKUP_IDX("pxa-gpio", SPITZ_GPIO_LED_GREEN, NULL, 1,
+                               GPIO_ACTIVE_HIGH),
+               { }
+       }
+};
+
 static struct gpio_led spitz_gpio_leds[] = {
        {
                .name                   = "spitz:amber:charge",
                .default_trigger        = "sharpsl-charge",
-               .gpio                   = SPITZ_GPIO_LED_ORANGE,
        },
        {
                .name                   = "spitz:green:hddactivity",
                .default_trigger        = "disk-activity",
-               .gpio                   = SPITZ_GPIO_LED_GREEN,
        },
 };
@@ -480,6 +489,7 @@ static struct platform_device spitz_led_device = {

 static void __init spitz_leds_init(void)
 {
+       gpiod_add_lookup_table(&spitz_led_gpio_table);
        platform_device_register(&spitz_led_device);
 }
 #else

--
2.42.0
Which driver consumes these GPIOs? Doesn't it need any conversion?

Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help