Re: [PATCH 05/15] platform/x86/amd/pmf: change debugfs init sequence
From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Date: 2023-09-26 16:54:05
Also in:
amd-gfx, dri-devel, platform-driver-x86
On Fri, 22 Sep 2023, Shyam Sundar S K wrote:
amd_pmf_dbgfs_register() needs to be called before amd_pmf_init_features().
Please answer to why? question too here.
quoted hunk ↗ jump to hunk
Hence change the sequence. Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com> --- drivers/platform/x86/amd/pmf/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c index 6f36c43e081e..dbfe7c1d6fc4 100644 --- a/drivers/platform/x86/amd/pmf/core.c +++ b/drivers/platform/x86/amd/pmf/core.c@@ -427,9 +427,9 @@ static int amd_pmf_probe(struct platform_device *pdev) apmf_acpi_init(dev); platform_set_drvdata(pdev, dev); + amd_pmf_dbgfs_register(dev); amd_pmf_init_features(dev); apmf_install_handler(dev); - amd_pmf_dbgfs_register(dev); dev_info(dev->dev, "registered PMF device successfully\n");
-- i.